Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Override build_type via rosdoc2 yaml #51

Merged
merged 2 commits into from
Apr 4, 2023
Merged

Feature: Override build_type via rosdoc2 yaml #51

merged 2 commits into from
Apr 4, 2023

Conversation

Yadunund
Copy link
Collaborator

@Yadunund Yadunund commented Apr 2, 2023

This PR allows users to pass an override_build_type parameter via the rosdoc2.yaml settings.

I've found this to be the easiest way to get document generation for rclpy like packages to work. ie, where the build_type in package.xml is ament_cmake but we want autodoc generation of the python modules within rclpy/rclpy.

@Yadunund
Allow build_type to be overwritten
44b970a 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
@Yadunund Yadunund requested review from audrow and tfoote as code owners April 2, 2023 10:09
@Yadunund Yadunund mentioned this pull request Apr 2, 2023
Merged
@Yadunund
Style
ace07a1 
Signed-off-by: Yadunund <yadunund@openrobotics.org>
tfoote
tfoote approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable as an option to add.

@clalancette clalancette merged commit 0a79553 into main Apr 4, 2023
@clalancette clalancette deleted the yadu/allow_build_type_override branch April 4, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfoote tfoote tfoote approved these changes

@clalancette clalancette clalancette approved these changes

@audrow audrow Awaiting requested review from audrow audrow is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Yadunund @clalancette @tfoote