Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup, approching pep8 pep257 compliance #56

Merged
merged 3 commits into from Aug 30, 2016

Conversation

Projects
None yet
2 participants
@mikaelarguedas
Copy link
Contributor

commented May 11, 2016

long due cleanup/linting

@nlyubova

This comment has been minimized.

Copy link
Member

commented Jun 5, 2016

@mikaelarguedas should we merge it?

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2016

I would like to actually test it on the new URDFs to see if anything broke along the way. Would you mind sending me (via PM) the latest URDFs for all robots? I will use them to validate any change on the generator

@mikaelarguedas mikaelarguedas force-pushed the python_cleanup branch from 57e8e83 to 0855387 Aug 29, 2016

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2016

Tested on the latest set of URDF files (thanks @nlyubova). Fixed typo accordingly and validated that the generated files are identical.
Waiting for review and can be squashed and merges

@nlyubova

This comment has been minimized.

Copy link
Member

commented Aug 29, 2016

Nice re-formatting ! did you actually change some values ? :) should we re-generate URDF with this new version?

@mikaelarguedas

This comment has been minimized.

Copy link
Contributor Author

commented Aug 29, 2016

Nope didn't change any value just refactored and cleanup the code. I compared the generated urdfs using http://prettydiff.com/ amd the generated are exactly identical.
Once this is merged I'll add the changes we talked about a few months ago (adding dummy inertias automatically when needed etc)

@nlyubova

This comment has been minimized.

Copy link
Member

commented Aug 30, 2016

+1

@mikaelarguedas mikaelarguedas merged commit 70e4001 into master Aug 30, 2016

@mikaelarguedas mikaelarguedas deleted the python_cleanup branch Aug 30, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.