adding dwb param descriptions #31
Conversation
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
|
I think you should split the main page into 4 pages: dwb controller, iterator, kinematic parameters, visualization - along with the other separated pages. Its just too long. I think the main landing page here should just be a list of links to the other pages and then the full example below it. The DWB main-controller parameters should be first, then the other 3 on this main page, then the others you have listed. |
| @@ -1,11 +1,13 @@ | |||
| .. dwb_iterator: | |||
| .. _dwb_iterator: | |||
|
|
|||
| Iterator | |||
There was a problem hiding this comment.
I think this is the XYTheta iterator, not just the generic iterator.
| @@ -1,11 +1,13 @@ | |||
| .. dwb_kinematic_params: | |||
| .. _dwb_kinematic_params: | |||
|
|
|||
| Kinematics | |||
There was a problem hiding this comment.
this should also be the full name like the iterator page. Kinematic Parameters
| @@ -1,11 +1,13 @@ | |||
| .. dwb_vis: | |||
| .. _dwb_vis: | |||
|
|
|||
| Visualization | |||
There was a problem hiding this comment.
As well here, use the full name
There was a problem hiding this comment.
Full name for this is Publisher, right?
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
|
Reminder to self: post on discourse about this when this is in. Last PR before complete |
|
@Marwan99 please delete the https://navigation.ros.org/configuration/params/tunable-params.html |
|
Looks like you have a couple of merge conflicts the draft PR was hiding |
|
Congrats @Marwan99! This was a big effort and we got it done in a couple weeks. What's your discourse handle? |
|
Thanks @SteveMacenski, appreciate your guidance and support! My discourse handle is marwan99, just created the account! |
|
Celebrate the small victories or no one else will :-) |
|
Should we tick the first item in this list? ros-navigation/navigation2#1589 (comment) |
|
good call, done |
per #21
All DWB param descriptions should be there now. (hardest part completed). Examples to be added.
@SteveMacenski What do think of the layout? Any suggestions on where the publish and kinematic parameters should live?