Skip to content

Rpp curve regulation reference cycle#3414

Merged
SteveMacenski merged 8 commits intoros-navigation:mainfrom
fireflyautomatix:rpp-curve-regulation-reference-cycle
Feb 24, 2023
Merged

Rpp curve regulation reference cycle#3414
SteveMacenski merged 8 commits intoros-navigation:mainfrom
fireflyautomatix:rpp-curve-regulation-reference-cycle

Conversation

@Aposhian
Copy link
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Primary OS tested on Ubuntu
Robotic platform tested on Custom: Sim and Real

Description of contribution in a few bullet points

Introduce option to set lookahead for curvature detection to a fixed distance. This breaks a reference cycle that becomes especially problematic with long lookaheads.

Description of documentation updates required from your changes

Added two new parameters.


Future work that may be required in bullet points

Determine if there is a way to derive this metric so that it can be enabled by default for all users

For Maintainers:

  • Check that any new parameters added are updated in navigation.ros.org
  • Check that any significant change is added to the migration guide
  • Check that any new features OR changes to existing behaviors are reflected in the tuning guide
  • Check that any new functions have Doxygen added
  • Check that any new features have test coverage
  • Check that any new plugins is added to the plugins page
  • If BT Node, Additionally: add to BT's XML index of nodes for groot, BT package's readme table, and BT library lists

@SteveMacenski
Copy link
Member

No real complaints -- though CI running is odd. Try rebasing?

@Aposhian Aposhian force-pushed the rpp-curve-regulation-reference-cycle branch from 84cbd87 to ee9116a Compare February 21, 2023 20:58
@Aposhian
Copy link
Contributor Author

Ok, the fork for our main branch must have been polluted when I was trying to run CI. I just rebased on upstream main.

@Aposhian
Copy link
Contributor Author

param guide here: ros-navigation/docs.nav2.org#390

@SteveMacenski
Copy link
Member

Still a few items above, but just details

@SteveMacenski SteveMacenski merged commit 72cae58 into ros-navigation:main Feb 24, 2023
@Aposhian Aposhian deleted the rpp-curve-regulation-reference-cycle branch February 24, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants