Rpp curve regulation reference cycle#3414
Merged
SteveMacenski merged 8 commits intoros-navigation:mainfrom Feb 24, 2023
Merged
Conversation
nav2_regulated_pure_pursuit_controller/src/regulated_pure_pursuit_controller.cpp
Outdated
Show resolved
Hide resolved
nav2_regulated_pure_pursuit_controller/src/regulated_pure_pursuit_controller.cpp
Show resolved
Hide resolved
Member
|
No real complaints -- though CI running is odd. Try rebasing? |
84cbd87 to
ee9116a
Compare
Contributor
Author
|
Ok, the fork for our main branch must have been polluted when I was trying to run CI. I just rebased on upstream main. |
Contributor
Author
|
param guide here: ros-navigation/docs.nav2.org#390 |
Member
|
Still a few items above, but just details |
SteveMacenski
approved these changes
Feb 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Introduce option to set lookahead for curvature detection to a fixed distance. This breaks a reference cycle that becomes especially problematic with long lookaheads.
Description of documentation updates required from your changes
Added two new parameters.
Future work that may be required in bullet points
Determine if there is a way to derive this metric so that it can be enabled by default for all users
For Maintainers: