Rename max_points to min_points polygon parameter#3513
Merged
SteveMacenski merged 2 commits intoros-navigation:mainfrom Mar 28, 2023
Merged
Rename max_points to min_points polygon parameter#3513SteveMacenski merged 2 commits intoros-navigation:mainfrom
SteveMacenski merged 2 commits intoros-navigation:mainfrom
Conversation
Member
|
LGTM. Just the docs PR for migration / config guide updates |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
colcon test --packages-select nav2_collision_monitorDescription of contribution in a few bullet points
<polygon_name>.max_pointsparameter was renamed to<polygon_name>.min_pointsto track its meaning<polygon_name>.max_pointsis still used (to be removed in the future releases), but now with deprecation warning, if parameter was set by developertestPolygonMaxPointstestcase formax_pointsdeprecated parameterDescription of documentation updates required from your changes
Future work that may be required in bullet points
<polygon_name>.max_pointsparameter in the further releasesFor Maintainers: