[controller_server] [FollowPath] Allow multiple progress checkers#3555
Merged
SteveMacenski merged 8 commits intoros-navigation:mainfrom May 17, 2023
Merged
Conversation
SteveMacenski
approved these changes
May 3, 2023
Member
There was a problem hiding this comment.
I generally approve, but I want to see the docs PR to match since there will be a bunch of places these new ports and vectorized plugins need to be set. Last time we did this, there were vestiges in docs of it for way too long causing problems with copy+pasting of YAML
Edit: I lied. See below.
Contributor
|
@doisyg, your PR has failed to build. Please check CI outputs and resolve issues. |
0fc13ce to
4bb1e20
Compare
SteveMacenski
requested changes
May 10, 2023
SteveMacenski
approved these changes
May 16, 2023
SteveMacenski
approved these changes
May 17, 2023
Member
|
Just waiting on CI |
enricosutera
pushed a commit
to enricosutera/navigation2
that referenced
this pull request
May 19, 2024
…s-navigation#3555) * allow multiple progress checker plugin * merge conflict * handle change of progress checker during a preempt * reset pc on preempt * fix default declaration * Handle deprecated progress_checker_plugin * improve readability * Update nav2_controller/src/controller_server.cpp --------- Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: enricosutera <enricosutera@outlook.com>
savalena
pushed a commit
to savalena/navigation2
that referenced
this pull request
Jul 5, 2024
…s-navigation#3555) * allow multiple progress checker plugin * merge conflict * handle change of progress checker during a preempt * reset pc on preempt * fix default declaration * Handle deprecated progress_checker_plugin * improve readability * Update nav2_controller/src/controller_server.cpp --------- Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
The parameters
goal_checker_pluginsandcontroller_pluginsare list of strings, allowing multiple plugin configuration, whereasprogress_checker_pluginis a single string allowing the declaration of only one goal checker.This PR initializes the progress checker plugin(s) in the same way as for the goal checker and controller plugins: it is now a list of string and was renamed from
progress_checker_plugintoprogress_checker_plugins. This allows the initialization of multiple goal checker that can be chosen from the addedprogress_checker_idfield of theFollowPathactionThis is a breaking change as the configuration yaml has to be updated from
to
Description of documentation updates required from your changes
Future work that may be required in bullet points
For Maintainers: