Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boost 1.69 compatibility #379

Merged
merged 1 commit into from Apr 8, 2019

Conversation

de-vri-es
Copy link
Contributor

The signals library was not used at all, and it has been removed from boost 1.69. As a result, the package doesn't build anymore with boost 1.69 without this change.

The signals library was not used at all, and it has been removed from
boost 1.69. As a result, the package doesn't build anymore with boost
1.69 without this change.
@de-vri-es
Copy link
Contributor Author

Note: CI fails before actually testing these changes.

Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JWhitleyAStuff LGTM

I want to make sure someone else takes a look at things and approves and not just 1 persons' opinion

Copy link
Collaborator

@JWhitleyWork JWhitleyWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually sure why this was here in the first place.

@JWhitleyWork JWhitleyWork merged commit 3b67763 into ros-perception:indigo Apr 8, 2019
@SteveMacenski
Copy link
Member

May have been boiler plate at one point or used before CV windows

@de-vri-es
Copy link
Contributor Author

My guess: copy pasta from another CMakeLists.txt

generush pushed a commit to generush/image_pipeline that referenced this pull request May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants