Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[image_view] Request start/end saving request by std_srvs/Trigger #163

Merged

Conversation

Projects
None yet
2 participants
@wkentaro
Copy link
Member

commented Nov 24, 2015

No description provided.

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch 2 times, most recently from 92dad7b to 71fa1ca Nov 24, 2015

@wkentaro wkentaro changed the title Request start/end saving request by header message [image_view/image_saver] Request start/end saving request by header message Nov 24, 2015

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2015

Could you please review and merge?

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch 2 times, most recently from abc03ea to bc79a91 Dec 3, 2015

@vrabaud

This comment has been minimized.

Copy link
Contributor

commented Dec 6, 2015

a header seems like a heavy interface ? Why not a dynamic parameter that is a ros::Time ?

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2015

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Dec 7, 2015

In that case, dynamic parameter interface is heavier I think.

wkentaro added a commit to wkentaro/jsk_recognition that referenced this pull request Dec 17, 2015

[jsk_perception] Add utils to save images by request or from bagfile
I sent PR to upstream:

- ros-perception/image_pipeline#159
- ros-perception/image_pipeline#163
- ros-perception/image_pipeline#164

Added:
	 jsk_perception/node_scripts/extract_images_sync
	 jsk_perception/node_scripts/image_saver_sync
	 jsk_perception/node_scripts/publish_header

wkentaro added a commit to wkentaro/jsk_recognition that referenced this pull request Dec 17, 2015

[jsk_perception] Add utils to save images by request or from bagfile
I sent PR to upstream:

- ros-perception/image_pipeline#159
- ros-perception/image_pipeline#163
- ros-perception/image_pipeline#164

Added:
	 jsk_perception/node_scripts/extract_images_sync
	 jsk_perception/node_scripts/image_saver_sync
	 jsk_perception/node_scripts/publish_header
@vrabaud

This comment has been minimized.

Copy link
Contributor

commented Jan 2, 2016

ok, you are right about dynamic_reconfigure.
The simplest you should use is a trigger service: http://docs.ros.org/api/std_srvs/html/srv/Trigger.html Please also need to rebase.
Very very sorry about the slowness these days, life gets in the way ...

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch from bc79a91 to 1ec22f5 Feb 14, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2016

The reason I used header as the request is to pass the timestamp to the image_view.
With trigger service, it cannot pass the timestamp so there will be a time lag between the time user really requests and actual one.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2016

But I can use the rostime when the Trigger service is requested as the time user desires, so I will do that.

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch from 1ec22f5 to 78b2474 Feb 14, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2016

I have done. Please review again.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented May 24, 2016

Friendly, ping.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2016

ping.

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2016

ping

@wkentaro wkentaro changed the title [image_view/image_saver] Request start/end saving request by header message [image_view/image_saver] Request start/end saving request by std_srvs/Trigger Jul 12, 2016

@wkentaro wkentaro changed the title [image_view/image_saver] Request start/end saving request by std_srvs/Trigger [image_view] Request start/end saving request by std_srvs/Trigger Jul 12, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2016

ping

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch from 78b2474 to 790f573 Jul 15, 2016

@wkentaro wkentaro force-pushed the wkentaro:indigo-image_saver-with-header-request branch from 790f573 to 1370cd4 Jul 16, 2016

@wkentaro wkentaro closed this Jul 18, 2016

@wkentaro wkentaro reopened this Jul 18, 2016

@vrabaud vrabaud merged commit 2846d95 into ros-perception:indigo Jul 24, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vrabaud

This comment has been minimized.

Copy link
Contributor

commented Jul 24, 2016

Very very sorry for the delay, life got inthe way ...

@wkentaro wkentaro deleted the wkentaro:indigo-image_saver-with-header-request branch Jul 24, 2016

@wkentaro

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2016

Never mind. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.