Apply clang-tidy fixes #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BryceStevenWilley
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
LGTM, just fixing auto in loops.
However, I don't think this will fix ros-planning/moveit#1607 (comment), if that's what it's intended for. I think that's a missing override in shapes. If not, carry on. :)
| @@ -145,9 +145,9 @@ void bodies::computeBoundingSphere(const std::vector<const bodies::Body*>& bodie | |||
|
|
|||
| // TODO - expand to all body types | |||
| unsigned int vertex_count = 0; | |||
| for (unsigned int i = 0; i < bodies.size(); i++) | |||
| for (auto body : bodies) | |||
There was a problem hiding this comment.
Should fix auto in loops.
That's true. Due to its urgency, I fixed the mentioned issue directly via #113. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply the most important clang-tidy fixes. I just dropped the naming conventions of MoveIt, because they are not followed in this rep.