Changed retriever.h to retriever.hpp in mesh_operations.cpp #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to align with resource_retriever ros2 branch
vatanaksoytezer
approved these changes
Jul 20, 2021
|
@Drojas251 thanks for reporting, indeed they seem to remove this header with ros/resource_retriever#63. This change will not compile on Foxy, so I think we would have to branch off for foxy at this point. Pinging @tylerjw and @henningkayser to let the CI run and branch off for foxy. |
|
@tylerjw can you approve the CI for this PR? We should merge this if CI passes. |
tylerjw
approved these changes
Jul 29, 2021
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error found when building ROS2 Rolling and Moveit2 from source. the resource_retriever ros2 branch removed depreciated retriever.h header file