Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moveit regression on Melodic #1154

Closed
clalancette opened this issue Oct 26, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@clalancette
Copy link
Contributor

commented Oct 26, 2018

Description

Most of Moveit is currently failing to build on the Melodic build farm. The root of the issue seems to be that moveit_ros_planning is failing to build, which causes a cascade of failures further down the line. It looks like moveit_ros_planning is failing to build because of a missing package.xml dependency on cmake_modules: http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_ros_planning__ubuntu_bionic_amd64__binary/16/console . If we could get that in and released soon, that would be great as I'm planning to do a Melodic sync next week: https://discourse.ros.org/t/preparing-for-melodic-sync-2018-11-01/6608 . Otherwise, I'll likely downgrade Moveit for that sync and we can get it fixed for the next sync cycle. Thanks!

@welcome

This comment has been minimized.

Copy link

commented Oct 26, 2018

Thanks for reporting an issue. We will have a look asap. If you can think of a fix, please consider providing it as a pull request.

@moriarty

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

I think this is missing in moveit_ros/planning/planning_request_adapter_plugins/CMakeLists.txt because of #1012. I will submit a PR

moriarty added a commit to moriarty/moveit that referenced this issue Oct 26, 2018

[CMake] add build depend on cmake_modules
Fix ros-planning#1154. The only CMakeLists.txt which didn't have a build_depend
and used cmake_modules:

    planning/planning_request_adapter_plugins/CMakeLists.txt:  cmake_modules

@moriarty moriarty referenced this issue Oct 26, 2018

Closed

[CMake] add build depend on cmake_modules #1161

0 of 7 tasks complete

moriarty added a commit to moriarty/moveit that referenced this issue Oct 26, 2018

[CMake] add build depend on cmake_modules
Backport ros-planning#1161

Fix ros-planning#1154. The only CMakeLists.txt which didn't have a build_depend
and used cmake_modules:

    planning/planning_request_adapter_plugins/CMakeLists.txt:  cmake_modules

@moriarty moriarty referenced this issue Oct 26, 2018

Closed

[CMake] add build depend on cmake_modules #1163

0 of 7 tasks complete
@moriarty

This comment has been minimized.

Copy link
Contributor

commented Oct 26, 2018

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2018

@davetcoleman Your bot is definitely not greeting first-time users only. Chris is a well-known friend ;-)

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Oct 26, 2018

@clalancette We already tackled this issue in #1134.
@130s promised to do a new release this weekend.

@rhaschke rhaschke closed this Oct 26, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Oct 27, 2018

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Oct 27, 2018

@clalancette

This comment has been minimized.

Copy link
Contributor Author

commented Oct 29, 2018

@clalancette We already tackled this issue in #1134.
@130s promised to do a new release this weekend.

Perfect, thanks. I merged the new release into Melodic, and it is building now :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.