Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201811 release #1225

Closed
130s opened this Issue Nov 25, 2018 · 25 comments

Comments

Projects
None yet
5 participants
@130s
Copy link
Member

130s commented Nov 25, 2018

Pending PRs / issues:

Coordinated releases:

@130s 130s added the release label Nov 25, 2018

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Nov 26, 2018

I'm waiting for the sync of tf2_eigen on Nov, 27th. Which open issues / PRs (other than #1096) should be merged?

(List is moved to OP #1225 (comment))

@rhaschke rhaschke referenced this issue Nov 26, 2018

Closed

cleanup chomp stuff #1136

3 of 5 tasks complete
@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Nov 26, 2018

Can we always communicate about release in a explicitly designated ticket

Yes please! 😕

As explained in #1166 (comment) , I would prefer to hold off until end of next week to have time to test changes.

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Nov 28, 2018

As @davetcoleman already started the release-cycle with rviz-visual-tools, the ROS build farm is breaking:
http://build.ros.org/view/Mbin_uB64/job/Mbin_uB64__moveit_visual_tools__ubuntu_bionic_amd64__binary

For this reason, I suggest to continue with the release process. This way, we have enough soaking time before the next sync. I think, it's better to test those changes in a larger community (of shadow-fixed users) instead of restricting to "from-source builders".
@v4hn @130s @davetcoleman Opinions?

@davetcoleman

This comment has been minimized.

Copy link
Member

davetcoleman commented Nov 28, 2018

Seems a little rushed to me to make a release since we just did one...

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Nov 29, 2018

Seems a little rushed to me to make a release since we just did one.

This release comprises many API changes and we should release them as early as possible - before many people have adopted Melodic in a production environment and then would face API changes in the middle of a stable release. I think, we agreed that big API changes like these should be merged (and released) asap before freezing API again (by the end of the year?)

2nd argument is, that the MoveIt jobs on ROS build farm are broken right now:

  • dev jobs are broken, because they are missing binary releases comprising the required API changes
  • bin jobs are broken, because @davetcoleman already triggered the release process by releasing rviz_visual_tools.
    Remember that we agreed that it will be important to release all packages at once.

3rd argument: The next sync will happen in about two weeks, probably with a freeze a week before again. Hence, waiting for another week, we again risk to run into the freezing phase, which makes it a little harder to merge release requests (needs extra communication).

4th argument: Releasing to shadow-fixed will reach a larger community for testing than relying on from-source-builds.

Finally, I am using my changes in production since several weeks.

@davetcoleman

This comment has been minimized.

Copy link
Member

davetcoleman commented Dec 3, 2018

These are good arguments, sounds good to me.

bin jobs are broken, because @davetcoleman already triggered the release process by releasing rviz_visual_tools.

Notably, you are the one who asked me to make that release :-)

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 8, 2018

I would like to the release on the weekend. Any objections?

@130s

This comment has been minimized.

Copy link
Member Author

130s commented Dec 9, 2018

No objections. Just noticed there are still a few open items in the list #1225 (comment)

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 9, 2018

Please feel free to review them ;-)
If I don't get reviews, I will merge them anyway.

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 9, 2018

Release triggered: ros/rosdistro#19662

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 10, 2018

Release build was successful: Melodic build status.
However, as pointed out in #1251 (comment), removing moveit_experimental from the set of released packages, doesn't automatically uninstalls this package. Thus, when updating to 0.10.6, we get a clash:
E: /tmp/apt-dpkg-install-i6AXUC/02-ros-melodic-moveit-core_0.10.6-0bionic.20181210.112240_amd64.deb: trying to overwrite '/opt/ros/melodic/include/moveit/collision_distance_field/collision_common_distance_field.h', which is also in package ros-melodic-moveit-experimental 0.10.5-0bionic.20181117.194840

@clalancette Is there a way to automatically uninstall removed packages?

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 10, 2018

Alternatively, could we release a new, empty moveit_experimental package, i.e. remove the redundant file(s) by updating moveit_experimental?

@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Dec 10, 2018

@rhaschke This is debian package management. We could in theory add a conflict between current moveit_core and moveit_experimental to force the user to uninstall, but even if bloom supports this it's rather ugly.

I believe the only reasonable way out is to release moveit_experimental once more with the collision_distance_field components gone. It seems stupid to release an empty package, but that's the road we chose when we released moveit_experimental before..

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 10, 2018

Two guys, one idea... Waiting for feedback from @clalancette.

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 10, 2018

OK, I will try this approach. Looks like the easiest one.

@clalancette

This comment has been minimized.

Copy link
Contributor

clalancette commented Dec 10, 2018

Yeah, I agree with @v4hn that we should release moveit_experimental as an empty package, that way upgrades will be smooth for users.

@davetcoleman

This comment has been minimized.

Copy link
Member

davetcoleman commented Dec 10, 2018

Hurray empty debian packages!

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 11, 2018

Although, upgrading worked in principle, we have still an issue due to the wrong upgrade order (moveit-experimental being upgraded last):
https://hub.docker.com/r/moveit/moveit/builds/bxgqrlckusgbj9ta4a4ktr9

I prepared a new release, defining a (temporary) dependency from moveit-core to moveit-experimental:
ros/rosdistro#19677

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 11, 2018

With this latest release, both DockerHub and Travis are fine again. Release finished.

@rhaschke rhaschke closed this Dec 11, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

davetcoleman commented Dec 11, 2018

Thanks @rhaschke !

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 13, 2018

Triggered a new release, ros/rosdistro#19714, to fix regression #1259 / #1261.

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 17, 2018

@clalancette Could you please hold back the upcoming ROS Melodic sync a few more days?
The recent MoveIt release introduced some regressions: #1271, #1255, which I would like to get merged / fixed before.

@rhaschke rhaschke reopened this Dec 17, 2018

@clalancette

This comment has been minimized.

Copy link
Contributor

clalancette commented Dec 17, 2018

@rhaschke That's fine, I'm still waiting on the pilz_industrial_motion release before I go into freeze anyway. If that gets done this week, but you still aren't ready, I'll start the freeze with an explicit exception for MoveIt.

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 24, 2018

Triggered a new release 0.10.8: ros/rosdistro#19825

@rhaschke

This comment has been minimized.

Copy link
Collaborator

rhaschke commented Dec 29, 2018

0.10.8 released and synced.

@rhaschke rhaschke closed this Dec 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.