Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinetic Release #18

Closed
davetcoleman opened this issue Aug 4, 2016 · 79 comments

Comments

@davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Aug 4, 2016

Discussion moved from old repo: ros-planning/moveit_ros#695

Discuss here issues related to releasing Kinetic. We can track remaining issues in this new milestone: https://github.com/ros-planning/moveit/milestone/1

I don't think we can add milestones for issues in other repos. Creating that list here:

@davetcoleman davetcoleman mentioned this issue Aug 4, 2016
7 of 9 tasks complete
@davetcoleman davetcoleman added this to the Kinetic Release milestone Aug 4, 2016
wjwwood pushed a commit to wjwwood/moveit that referenced this issue Aug 4, 2016
…er-manager-cxx11

Fix conversion of shared ptr to bool for C++11.
@Rayman Rayman mentioned this issue Aug 16, 2016
92 of 98 tasks complete
@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Aug 26, 2016

I think we are nearing a beta version of the Kinetic release to bloom. The last thing I'd personally like to see before releasing is a switch to C++11 shared_ptrs in the public header, which is in progress at #48 thanks to @de-vri-es

Is there anything else we need to wait for? Even when we release Kinetic I think we should not consider it "stable" / worry about ABI for a while longer

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Aug 26, 2016

On Fri, Aug 26, 2016 at 10:24:36AM -0700, Dave Coleman wrote:

Is there anything else we need to wait for?

I'm not sure right now.

I believe I would like to see #80 resolved
to settle open issues in the message API for kinetic. I have one other change to the Grasp
message that I would like to see in kinetic, but I didn't get around to provide a MoveIt patch for it yet...

I know moveit_msgs is already released, but we could surely change things before releasing MoveIt itself.
Btw: what was the reason for already releasing the messages? I suppose you did that @130s?

Even when we release Kinetic I think we should not consider it "stable" / worry about ABI for a while longer

+1

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Aug 26, 2016

what was the reason for already releasing the messages?

To make a release of a package there should be debs of all dependent packages already available, and generating debs in shadow repo for the first time takes certain amount of time (usually 3+ days?). Once it's released, the successive release takes less time for debs to be built. Since I thought moveit_msgs and other packages that are depended by packages in moveit repo are more stable, I wanted to have them released well in advance so that once we're ready to make a Kinetic release we won't have to wait for dependent packages.

Also, I think I've already made multiple version up release of moveit_msgs. Reason is because every time new release into other distros (IJ) it's so easier to make a release into K as well to simply not forget to release...Not smart though.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Aug 26, 2016

I know moveit_msgs is already released, but we could surely change things before releasing MoveIt itself.

For sure. But we should move quick on this.

@VictorLamoine

This comment has been minimized.

Copy link
Contributor

@VictorLamoine VictorLamoine commented Sep 12, 2016

Do you know when all MoveIt packages will be released for Kinetic?

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Sep 12, 2016

I've just updated the top comment (above) with the remaining blockers for Kinetic. I think we should close those issues ASAP and get kinetic out - its been 4 months since ROS Kinetic was released so I know we need to get it moving! A rough estimation based: 1 month

@VictorLamoine

This comment has been minimized.

Copy link
Contributor

@VictorLamoine VictorLamoine commented Sep 13, 2016

Thank you for the update, don't hesitate to ask me if you require external testers.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Sep 13, 2016

You're welcome to use/test the kinetic branch from source now :)

@arpit15

This comment has been minimized.

Copy link

@arpit15 arpit15 commented Sep 28, 2016

@VictorLamoine were you able to catkin_make the kinetic version.
My make is failing and giving errors of "conflicting declaration" with geometric_shapes and srdf

@davetcoleman are there any updates about release for kinetic.

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Sep 28, 2016

On Wed, Sep 28, 2016 at 01:11:17PM -0700, Arpit Agarwal wrote:

@VictorLamoine were you able to catkin_make the kinetic version.
My make is failing and giving errors of "conflicting declaration" with geometric_shapes and srdf

Please follow the instructions on http://moveit.ros.org/install/source/
You need to checkout and build geometric_shapes and srdfdom too at the moment.

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Sep 28, 2016

You need to checkout and build geometric_shapes and srdfdom too at the moment.

Maybe a bit hacky but if you're familiar with how to use shadow repository, those 2 pkgs are already available from there so that you don't need to build from source.

If anyone has more questions about source build, I suggest to open a new issue -- this ticket should be saved for release task discussion :)

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Oct 9, 2016

Sorry if I missed anything but what about ros-interactive-manipulation/manipulation_msgs#9

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Oct 9, 2016

On Sun, Oct 09, 2016 at 03:12:43AM -0700, Isaac I.Y. Saito wrote:

Sorry if I missed anything but what about ros-interactive-manipulation/manipulation_msgs#9

This has been partially resolved in ros-planning/moveit_msgs#32
and #264 .

If the dependency on manipulation_msgs should be avoided from the first kinetic release (+1), either

or

  • most of the glue-code can be simplified and the interface can be changed to ros-planning/moveit_msgs#32 . This would still leave the problem I explained in #246 though.

Both options are easy to do. I could probably do this earliest the week after next though.

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Oct 9, 2016

I just added #273 to the check list, which should allow us to change ABIs within ROS distributions in the future without having to tell the whole user-base to recompile their code.

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Oct 10, 2016

Notice that the main reason I consider #232 to block the kinetic-devel release is that it is ABI incompatible. It depends on the outcome of #273 whether this will remain a problem or not.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 11, 2016

Its not clear to me what @130s and @v4hn are discussing here regarding manipulation_msgs due to an over-use of links to other issues. You want to entirely remove the dependency on manipulation_msgs from the kinetic release of MoveIt!? Perhaps we can move this conversation to a dedicated issue thread?

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 14, 2016

I would really like to release kinetic in time for our Community Meeting. Thoughts on the various blockers:

  • #283 @v4hn reports the PR2 is broken because of the new start state validation feature. We should do a quick and dirty disable of this feature using a if (false) but leave the logic in there for ABI purposes. In the next Kinetic release we will hopefully have a proper fix. @rhaschke do you mind disabling the feature temporarily?
  • #232 - looks like this is ready to merge (minus a tiny style change). @Jntzko reported an issue when testing this, but it was related to the start state validation feature #283, which I am proposing we temporarily disable
  • #273 - everyone is happy with adding SONAMES, @v4hn just needs to finish applying the change to all moveit packages in this repo.

Its been almost 5 months since the ROS Kinetic release, we are behind! "The enemy of success is perfection"

@rhaschke

This comment has been minimized.

Copy link
Collaborator

@rhaschke rhaschke commented Oct 14, 2016

Regarding #283: I don't mind to disable the feature. I could also introduce a normalization of revolute joints there. Is the information about revolute joints available there?

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 14, 2016

I could also introduce a normalization of revolute joints there.

Certainly we want that also, but I just think we should hold off until the next release for actually enabling this feature to avoid further delays.

@mahmoudabdulazim

This comment has been minimized.

Copy link

@mahmoudabdulazim mahmoudabdulazim commented Oct 16, 2016

Hello, how much time as a rough estimate remains before ROS Kinetic moveit package release?

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 16, 2016

@mahmoudabdulazim I realize there are many ROS users holding back from upgrading to Kinetic because of MoveIt! (which is sad), and we are working hard to finish releasing it. I would like to see it released by the Oct 27th community meeting. Because there will likely be unforeseen release issues, we should ideally start releasing it this week.

To speed up the release, I propose we temporarily disable a new feature that is still buggy: #287

I also think we should hold back #232 until right after our first Kinetic release, so we have plenty of time to test it and we don't release a buggy new feature.

Therefore, the only blocker for Kinetic remaining is #273

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Oct 17, 2016

Assuming we want to have binary of initial release version of MoveIt! on Kinetic by the community meeting on 10/27, I propose day-by-day schedule deadlines from now on (in Pacific time). :

10/27 MCM (MoveIt! Community Meeting)
10/24 Very last call for the release request (note-2)
10/19 Last day to make initial release request (note-1)
10/17 Today

note-1...Initial release takes longer to build on ROS buildfarm. Combined with the software size, I'd say we want to save 5 days for building initial release version. By making a release on 19th, hopefully the binary will be ready on shadow repo by 24th.

note-2...Again with the size of the software released from moveit repo, I'd say we want 3 days for it to be built and become available on shadow repo. Making a release on 24th hopefully makes the binary ready by 27th.

With this strict timeframe I think there's little chance that MoveIt! makes it to the official repo by MCM.

@jiapd

This comment has been minimized.

Copy link

@jiapd jiapd commented Oct 18, 2016

Good luck! : )

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 18, 2016

Thank you @130s for the timeline summary.

I believe if we just postpone this questionable feature #287 we are ready for the release - I've been trying hard, with the help of many others, to get this out the door for 4 months and we must draw the line somewhere. The Community Meeting is an ideal time to draw that line.

I think we should skip the sonames for now since that PR #273 is not ready.

So we just need someone to merge #287 who is not me, the author.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 18, 2016

After @mikeferguson's viewpoint, I've closed #287 in favor of getting new features (possibly buggy) out quickly in our first Kinetic release for testing.

@130s in my opinion we are ready to start releasing Kinetic now.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Oct 31, 2016

No, as explained #319 (comment)

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 3, 2016

ping @130s - can we finish up the Kinetic release?

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 5, 2016

Prerelease test for Wily and Xenial passed locally!

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 5, 2016

Sorry web browser is getting cranky, have to post multiple times.


Prerelease test for Wily and Xenial passed locally!

Just a record for the release maintainance task: This time again I had to mess the commits a little bit (much better than the last time :p) for the following reasons that I'll have to fix for the future release:

  • catkin_generate_changelog didn't update CHANGELOG.rst files in a lot of packages in the repo. Didn't take note this time though, I feel like there's something for the tool with the large repository like moveit where folder/package structure isn't the simplest.
  • Following packages(/folders) somehow didn't get their versions incremented in package.xml files by catkin_prepare_release. Similar/the same issue with this question of mine. This time again I manually updated the changelog for these packages, committed and pushed a new tag:
    • moveit_controller_manager_example
    • moveit_fake_controller_manager
    • moveit_plugins
    • moveit_ros_control_interface
    • moveit_simple_controller_manager
    • benchmarks
    • planning_interface
    • warehouse
  • bloom complains that there were packages with different versions in the repo, which I manually adjusted by incrementing the versions that are smaller to higher (0.9.1 to 0.9.2 this time).
  • bloom-release also warns many times that there are packages from this repo that are not listed on rosdistro, e.g. chomp*. I didn't see this for the last time release into Kinetic, so I might have done something wrong. bloom allows to skip those so that we can still make a release without releasing those we don't want to release.
@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 5, 2016

rosdistro: ros/rosdistro#13138

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 5, 2016

@tfoote the buildfarm says "This job has been disabled by 'Disable Failed Job Plugin' due to consecutive failures. This project is currently disabled" but now that we've fixed Wily I think it needs re-enabling.

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 6, 2016

Not sure what is ros/rosdistro#13139 but I'll look into it.

@tfoote

This comment has been minimized.

Copy link
Member

@tfoote tfoote commented Nov 7, 2016

@130s The bloom process only generated a fraction of the tags necessary. It seemed to run the first stage for generic release tags, but not generate any of the platform specific tags.

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 9, 2016

@tfoote Sorry but I haven't fully understood the problem yet. Was it just during the last bloom run something went wrong that can be fixed by the new bloom run? Or is there something that needs to be fixed before/after the new bloom run?

@tfoote

This comment has been minimized.

Copy link
Member

@tfoote tfoote commented Nov 9, 2016

Not all the tags and branches were created by the last bloom run. A rerun watching the console output carefully for errors will either reveal the problem or hopefully just fix it. Likely one of the push steps failed. So I'd suggest trying bloom again and make sure to retain the logs and console output in case there's still a problem.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 15, 2016

Now that #357 should be addressed, we're ready to try releasing Kinetic again

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 15, 2016

Prerelease test for Xenial failed. I'll need to look deeper but I assume this will be fixed once the newest moveit_msgs binary becomes available?

generate_prerelease_script.py   https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml   kinetic default ubuntu xenial amd64   moveit   --level 0   --output-dir ./
:
[ 55%] Built target object_recognition_msgs_generate_messages_cpp
Scanning dependencies of target moveit_move_group_interface
[ 61%] Building CXX object move_group_interface/CMakeFiles/moveit_move_group_interface.dir/src/move_group_interface.cpp.o
/tmp/catkin_workspace/src/moveit/moveit_ros/planning_interface/move_group_interface/src/move_group_interface.cpp:60:39: fatal error: moveit_msgs/GraspPlanning.h: No such file or directory
compilation terminated.
move_group_interface/CMakeFiles/moveit_move_group_interface.dir/build.make:62: recipe for target 'move_group_interface/CMakeFiles/moveit_move_group_interface.dir/src/move_group_interface.cpp.o' failed
make[2]: *** [move_group_interface/CMakeFiles/moveit_move_group_interface.dir/src/move_group_interface.cpp.o] Error 1
CMakeFiles/Makefile2:3152: recipe for target 'move_group_interface/CMakeFiles/moveit_move_group_interface.dir/all' failed
make[1]: *** [move_group_interface/CMakeFiles/moveit_move_group_interface.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
<== Failed to process package 'moveit_ros_planning_interface': 
  Command '['/tmp/catkin_workspace/install_isolated/env.sh', 'make', '-j1']' returned non-zero exit status 2

Reproduce this error by running:
==> cd /tmp/catkin_workspace/build_isolated/moveit_ros_planning_interface && /tmp/catkin_workspace/install_isolated/env.sh make -j1

Command failed, exiting.
# END SUBSECTION
@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 15, 2016

Prerelease test for Xenial failed. I'll need to look deeper but I assume this will be fixed once the newest moveit_msgs binary becomes available?

moveit_msgs 0.9.0, which includes ros-planning/moveit_msgs#32, is already released and being built on buildfarm should fix this. We shouldn't even need ros-planning/moveit_msgs#35 to make Kinetic release I suppose.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 16, 2016

moveit_msgs has finished building on the buildfarm successfully

@130s

This comment has been minimized.

Copy link
Member

@130s 130s commented Nov 16, 2016

Prerelease test passed for Xenial, but not for Wily.

If I'm not mistaken something is happening around urdf_headers but no idea why the error only occurs for Wily.

$ generate_prerelease_script.py   https://raw.githubusercontent.com/ros-infrastructure/ros_buildfarm_config/production/index.yaml   kinetic default ubuntu wily amd64   moveit   --level 0   --output-dir ./
./prerelease.sh
:
Scanning dependencies of target test_constraint_samplers
[ 94%] Building CXX object constraint_samplers/CMakeFiles/test_constraint_samplers.dir/test/test_constraint_samplers.cpp.o
[ 96%] Building CXX object constraint_samplers/CMakeFiles/test_constraint_samplers.dir/test/pr2_arm_kinematics_plugin.cpp.o
[ 98%] Building CXX object constraint_samplers/CMakeFiles/test_constraint_samplers.dir/test/pr2_arm_ik.cpp.o
In file included from /tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:39:0:
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.h:170:34: error: ‘urdf::JointConstSharedPtr’ has not been declared
   void addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info);
                                  ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp: In member function ‘bool pr2_arm_kinematics::PR2ArmIK::init(const urdf::ModelInterface&, const string&, const string&)’:
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:61:3: error: ‘LinkConstSharedPtr’ is not a member of ‘urdf’
   urdf::LinkConstSharedPtr link = robot_model.getLink(tip_name);
   ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:64:5: error: ‘JointConstSharedPtr’ is not a member of ‘urdf’
     urdf::JointConstSharedPtr joint;
     ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:65:15: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
     if (link->parent_joint)
               ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:66:7: error: ‘joint’ was not declared in this scope
       joint = robot_model.getJoint(link->parent_joint->name);
       ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:66:42: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
       joint = robot_model.getJoint(link->parent_joint->name);
                                          ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:67:10: error: ‘joint’ was not declared in this scope
     if (!joint)
          ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:69:17: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
       if (link->parent_joint)
                 ^
In file included from /tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:38:0:
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:70:52: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
         logError("Could not find joint: %s", link->parent_joint->name.c_str());
                                                    ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:72:55: error: request for member ‘name’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
         logError("Link %s has no parent joint", link->name.c_str());
                                                       ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:75:9: error: ‘joint’ was not declared in this scope
     if (joint->type != urdf::Joint::UNKNOWN && joint->type != urdf::Joint::FIXED)
         ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:77:35: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
       link_offset.push_back(link->parent_joint->parent_to_joint_origin_transform);
                                   ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:110:33: error: request for member ‘parent_joint’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
       addJointToChainInfo(link->parent_joint, solver_info_);
                                 ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:113:38: error: request for member ‘getParent’ in ‘link’, which is of non-class type ‘int(const char*, const char*) throw ()’
     link = robot_model.getLink(link->getParent()->name);
                                      ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp: At global scope:
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:153:42: error: variable or field ‘addJointToChainInfo’ declared void
 void PR2ArmIK::addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info)
                                          ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:153:36: error: ‘JointConstSharedPtr’ is not a member of ‘urdf’
 void PR2ArmIK::addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info)
                                    ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:153:102: error: expected primary-expression before ‘&’ token
 void PR2ArmIK::addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info)
                                                                                                      ^
/tmp/catkin_workspace/src/moveit/moveit_core/constraint_samplers/test/pr2_arm_ik.cpp:153:103: error: ‘info’ was not declared in this scope
 void PR2ArmIK::addJointToChainInfo(urdf::JointConstSharedPtr joint, moveit_msgs::KinematicSolverInfo &info)
                                                                                                       ^
constraint_samplers/CMakeFiles/test_constraint_samplers.dir/build.make:100: recipe for target 'constraint_samplers/CMakeFiles/test_constraint_samplers.dir/test/pr2_arm_ik.cpp.o' failed
make[3]: *** [constraint_samplers/CMakeFiles/test_constraint_samplers.dir/test/pr2_arm_ik.cpp.o] Error 1
make[2]: *** [constraint_samplers/CMakeFiles/test_constraint_samplers.dir/all] Error 2
CMakeFiles/Makefile2:4956: recipe for target 'constraint_samplers/CMakeFiles/test_constraint_samplers.dir/all' failed
CMakeFiles/Makefile2:1753: recipe for target 'CMakeFiles/tests.dir/rule' failed
make[1]: *** [CMakeFiles/tests.dir/rule] Error 2
Makefile:862: recipe for target 'tests' failed
make: *** [tests] Error 2
<== Failed to process package 'moveit_core':
  Command '['/tmp/catkin_workspace/devel_isolated/moveit_commander/env.sh', 'make', '-j1', 'tests']' returned non-zero exit status 2

Reproduce this error by running:
==> cd /tmp/catkin_workspace/build_isolated/moveit_core && /tmp/catkin_workspace/devel_isolated/moveit_commander/env.sh make -j1 tests

Command failed, exiting.
# END SUBSECTION
@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 16, 2016

Whatever docker the pre-release test is using has not been updated for the last ROS buildfarm sync that includes the latest URDFDom headers we need. You might be using an old docker image cached on your computer. Try resetting all containers and images:

docker rm $(docker ps -a -q)                                                                                       
docker rmi $(docker images -q)  

Then re-run the prerelease. I'm testing the moveit build on Wily using Docker as we speak...

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 16, 2016

just verified: with the latest ROS Wily Docker moveit passes!

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 16, 2016

Except the tests were still failing, fixed in: #364

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 18, 2016

MoveIt! has fully passed on the buildfarm for X64 and W64! But we still have some failures in other platforms:

  • moveit_planners/moveit_planners_ompl: W32 and X32 - because the OMPL build is failing, see issue
  • moveit_setup_assistant: X32: perhaps a Docker error that will go away soon? Message: Cannot connect to the Docker daemon. Is the docker daemon running on this host? Indeed it fixed itself

Update: A broken OMPL test is now the only thing holding us back from releasing

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Nov 20, 2016

MoveIt! now fully builds for all Ubuntu platforms on the buildfarm! We're ready for the next sync.

@v4hn

This comment has been minimized.

Copy link
Member

@v4hn v4hn commented Nov 21, 2016

On Sun, Nov 20, 2016 at 12:21:05PM -0800, Dave Coleman wrote:

MoveIt! now fully builds for all Ubuntu platforms on the buildfarm! We're ready for the next sync.

nice!

@anderwm

This comment has been minimized.

Copy link
Contributor

@anderwm anderwm commented Dec 2, 2016

Out of curiosity, how often does this happen(sync)? I still don't see a ros-kinetic-moveit-full in Ubuntu

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Dec 2, 2016

Seems like about every month, but it largely depends on the build farm. You can track upcoming ones here: http://discourse.ros.org/c/release

No new Kinetic sync has been scheduled yet. If you started a discussion there, I bet it would help move it along.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

@davetcoleman davetcoleman commented Dec 16, 2016

Email announcement sent, blog post is up, and website is updated with install instructions for Kinetic. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.