Fixes setup_assistant custom planner ns problem #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 25, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 25, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
28 tasks
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
==========================================
+ Coverage 60.81% 60.82% +0.02%
==========================================
Files 366 366
Lines 31717 31717
==========================================
+ Hits 19286 19290 +4
+ Misses 12431 12427 -4
Continue to review full report at Codecov.
|
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
* Makes ompl planning_adapters argument optional (#27) This commit makes sure that the `planning_adapters` argument in the `ompl_planning_pipeline.launch.xml` launch file is optional. * Fixes custom planner ns bug This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
* Makes ompl planning_adapters argument optional (#27) This commit makes sure that the `planning_adapters` argument in the `ompl_planning_pipeline.launch.xml` launch file is optional. * Fixes custom planner ns bug (#30) This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842). * Adds missing package dependencies This commit adds several missing package dependencies. These package dependencies were commented to prevent installing gazebo be default. It was merged to be consistent with the 'moveit_setup_assistant' (see ros-planning/moveit#2839).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
v4hn
approved these changes
Aug 27, 2021
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 27, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
rickstaa
added a commit
to rickstaa/panda_moveit_config
that referenced
this pull request
Aug 30, 2021
This commit fixes a custom planner ns bug that was introduced by the `setup_assistant` (see ros-planning/moveit#2842).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on getting the Noetic branch of the panda_moveit_config ready (see rickstaa/panda_moveit_config#26) I noticed that the namespace of custom planners is not set correctly. The current template causes the default chomp planner to be loaded and listed in the MotionPlanning plugin:
While the stomp planner should be listed:
This bug might be new since the moveit_tutorial page shows the right figure.
Steps to reproduce the issue