cleanup urdfdom compatibility #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... relying on compatibility layer in urdf package partially reverts cbc28f1
davetcoleman
approved these changes
Oct 27, 2016
|
ros/robot_model#160 was released: ros/rosdistro#13092 and Travis' shadow-fixed build succeeded. @davetcoleman I think, this can be merged now. |
|
Seems mergeable to me but I'll wait for confirmation from others. |
|
I think this PR is low priority and should not be merged until the next buildfarm sync, so that our Travis tests don't fail for non-shadow-fixed, as @v4hn suggested. |
|
Merging because the compatibility layer is causing issues with the ROS buildfarm. This will unfortunately break our source build until the next release unless you are on shadow-fixed - I'll disable the Travis test for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up #317, relying on a compatibility layer in the upstream package
urdfinstead.Attention: This relies on ros/robot_model#160 and thus should only be merged when this upstream is released.