Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Indigo] 0.7.3 release build failure on ROS buildfarm #386

Closed
130s opened this issue Dec 22, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@130s
Copy link
Member

commented Dec 22, 2016

Related to #100

Looks like the build farm is failing to build moveit 0.7.3-0 particularly moveit_kinematics e.g. this job:

12:12:14 Traceback (most recent call last):
12:12:14   File "/tmp/ros_buildfarm/scripts/release/get_sources.py", line 48, in <module>
12:12:14     sys.exit(main())
12:12:14   File "/tmp/ros_buildfarm/scripts/release/get_sources.py", line 44, in main
12:12:14     args.os_name, args.os_code_name, args.source_dir)
12:12:14   File "/tmp/ros_buildfarm/ros_buildfarm/sourcedeb_job.py", line 59, in get_sources
12:12:14     (source_version, pkg_version))
12:12:14 RuntimeError: The cloned package version from the GBP (0.9.3-0trusty) does not match the expected package version from the distribution file (0.7.3-0)
12:12:14 Build step 'Execute shell' marked build as failure

Indeed I had to change the version of the package (i.e. downgrade from 0.9.3 to 0.7.2. This package was maintained with different version number and moved into this repo recently) in order for it to align with others in the same repo (if I remember correctly this was needed by catkin_prepare_release or bloom, or both?).

I'm not sure what to do to fix this case. @tfoote @dirk-thomas I'd appreciate if you could help.

@130s 130s self-assigned this Dec 22, 2016

@dirk-thomas

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2016

Your changelog contains a higher version (0.9.3) which ends up in the generate Debian changelog. You either have to strip every bit of information for those higher version numbers or avoid downgrading in the first place and release 0.9.4.

@130s

This comment has been minimized.

Copy link
Member Author

commented Dec 22, 2016

Thanks a lot Dirk. I would have never figured that out by myself.

Would it cause any similar issue if some of the package with smaller version (e.g. 0.5.7) than the one targeted at the release (0.7.3) are missing the Forthcoming section in their changelogs?
(Ideally I wanted to add changelogs for those packages once the release this time goes well #100 (comment). But it's already messed up so adding them manually can be an option this time).

@davetcoleman davetcoleman changed the title [Indigo] 0.7.3 relase build failure on ROS buildfarm [Indigo] 0.7.3 release build failure on ROS buildfarm Dec 22, 2016

130s added a commit to 130s/moveit that referenced this issue Dec 22, 2016

[indigo][changelog] Add blank 0.7.3 section to those that are missing…
… it.

Reason why doing this:
- catkin_generate_changelog gets stuck for some reason so batch generating changelog isn't possible now.
- Since this is the first release since 6 month ago for Indigo, lots of commit logs since then that shouldn't be wasted.
- Decided to bump version of all packages uniformely to 0.7.4 in the hope for catkin_generate_changelog to function...
- Turned out the accumulated commit logs are not retrieved...But we might as well want to move forward to fix ros-planning/moveit#386

130s added a commit that referenced this issue Dec 22, 2016

Merge pull request #387 from 130s/i/fix/386
[indigo] Changelog for 0.7.4 (preparing to fix #386)
@dirk-thomas

This comment has been minimized.

Copy link
Contributor

commented Dec 22, 2016

Looking at #387 it seems you have figured it out .

@130s

This comment has been minimized.

Copy link
Member Author

commented Dec 25, 2016

Yes, this particular issue was resolved at #387.

@130s 130s closed this Dec 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.