Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning Groups screen re-configured #1017

Conversation

Projects
None yet
4 participants
@MohmadAyman
Copy link
Member

commented Aug 6, 2018

Description

Planning Groups screen re-configured to solve spacing between items problems.

Checklist

  • Required: Code is auto formatted using clang-format
  • Include a screenshot if changing a GUI
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)
@gavanderhoorn

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

Why are "joints" recommended? We typically use chains (especially for serial manipulators), and those also work 'best' with IK plugins.

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2018

You have a point, but in this PR I honestly didn't look into the semantics. I just reconfigured the screen to look more cleaner than this

@gavanderhoorn

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

You're right. I assumed you had changed this.

Nevermind and sorry for the noise.

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2018

Its okay 👍

@davetcoleman davetcoleman merged commit 417ecd6 into ros-planning:kinetic-devel Aug 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davetcoleman added a commit that referenced this pull request Aug 6, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

cherry picked to melodic

@MohmadAyman MohmadAyman referenced this pull request Aug 20, 2018

Closed

Setup Assistant 2 #894

6 of 6 tasks complete

MohmadAyman added a commit to MohmadAyman/moveit that referenced this pull request Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.