Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all references to "MoveIt" to include exclamation mark e.g. "MoveIt!" #1020

Merged

Conversation

Projects
None yet
3 participants
@MohmadAyman
Copy link
Member

commented Aug 11, 2018

Description

Fix all references to "MoveIt" to include exclamation mark e.g. "MoveIt!".

Checklist

  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)
@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2018

This PR also applies clang format on the setup_assiatant_widgets. (second commit).

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 13, 2018

Somehow you ran the wrong type of clang-format - it should not have caused this many changes. Can you remove the "apply clang format" commit and try again using the instructions here:

http://moveit.ros.org/documentation/contributing/code/

Maybe you have the wrong version of clang-format?

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2018

Yes I've noticed that clang doesn't usually reorder includes according to their spelling, reinstalled it and works normally now, thanks.

@MohmadAyman MohmadAyman force-pushed the MohmadAyman:fix_references_to_moveit branch 2 times, most recently from a31b489 to b149204 Aug 13, 2018

@mcevoyandy
Copy link

left a comment

Looks good. Two nits on formatting.

structure describes that controller's state. */
struct ControllerState
{
ControllerState() : active_(false), default_(false)
{
}

/** \brief A controller can be active or inactive. This means that MoveIt could activate the controller when needed,
/** \brief A controller can be active or inactive. This means that MoveIt! could activate the controller when
needed,

This comment has been minimized.

Copy link
@mcevoyandy

mcevoyandy Aug 14, 2018

Fix wrapping with line below

and de-activate controllers that overlap (control the same set of joints) */
bool active_;

/** \brief It is often the case that multiple controllers could be used to execute a motion. Marking a controller as
default
makes MoveIt prefer this controller when multiple options are available. */
makes MoveIt! prefer this controller when multiple options are available. */

This comment has been minimized.

Copy link
@mcevoyandy

mcevoyandy Aug 14, 2018

text wrapping

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 18, 2018

Fixed text wrap 👍 @mcevoyandy

@MohmadAyman MohmadAyman force-pushed the MohmadAyman:fix_references_to_moveit branch from b149204 to 0f3229b Aug 18, 2018

@MohmadAyman MohmadAyman referenced this pull request Aug 20, 2018

Closed

Setup Assistant 2 #894

6 of 6 tasks complete

@davetcoleman davetcoleman merged commit 5162d5b into ros-planning:kinetic-devel Aug 22, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 22, 2018

cherry-pick: #1030

rhaschke added a commit that referenced this pull request Aug 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.