Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use panda robot in testing instead or pr2 #1042

Merged

Conversation

Projects
None yet
4 participants
@MohmadAyman
Copy link
Member

commented Aug 31, 2018

Description

  • Use panda robot in testing of moveit_config_data instead or pr2.
  • Write test temp file to /tmp instead of moveit_resources package.

Checklist

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Aug 31, 2018

@davetcoleman replaced pr2 by panda for the test.
@rhaschke now writes the test file to /tmp, waiting to see what ROS build server says now.

@rhaschke
Copy link
Collaborator

left a comment

I generally approve this. However, when switching from pr2 to panda, you should also update test_dependency in package.xml.

@MohmadAyman MohmadAyman force-pushed the MohmadAyman:ros_controllers_test branch from cb8ea41 to 9f2f4a4 Sep 1, 2018

@MohmadAyman

This comment has been minimized.

Copy link
Member Author

commented Sep 1, 2018

True! I've added moveit_resources as a test_depend.

@felixvd

felixvd approved these changes Sep 5, 2018

@rhaschke rhaschke merged commit 1a08a68 into ros-planning:kinetic-devel Sep 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davetcoleman

This comment has been minimized.

Copy link
Member

commented Sep 5, 2018

Thanks @felixvd for reviewing this!

Great work @MohmadAyman

rhaschke added a commit that referenced this pull request Sep 6, 2018

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Sep 6, 2018

Although the Panda robot was added to moveit_resources a while ago, this package wasn't released yet. Hence, now the ROS build-farm is failing due to a missing panda in moveit_resources. I fixed this issue by releasing version 0.6.4 of moveit_resources both into Kinetic and Melodic.

MohmadAyman added a commit to MohmadAyman/moveit that referenced this pull request Sep 11, 2018

ipa-hsd added a commit to ipa-hsd/moveit that referenced this pull request Mar 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.