Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-Pick #1033: Fix #868 #1057

Merged
merged 6 commits into from Sep 11, 2018

Conversation

Projects
None yet
2 participants
@rhaschke
Copy link
Collaborator

commented Sep 10, 2018

Cherry-Picking #1033 into Kinetic, with appropriate adaptions to handle old tf.

@rhaschke rhaschke requested a review from v4hn Sep 10, 2018

@davetcoleman
Copy link
Member

left a comment

Thanks for fixing this!

@davetcoleman davetcoleman merged commit b02ef29 into ros-planning:kinetic-devel Sep 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rhaschke rhaschke deleted the ubi-agni:kinetic-fix-868 branch Oct 5, 2018

ipa-hsd added a commit to ipa-hsd/moveit that referenced this pull request Mar 18, 2019

Cherry-Pick ros-planning#1033: Fix ros-planning#868 (ros-planning#1057)
* Revert "disable waitForCurrentRobotState() for PlanService capability (ros-planning#923)"

This reverts commit cf2217c.

* only waitForCurrentRobotState when start_state.is_diff

as discussed in ros-planning#868 (comment)

* reduce code duplication

* use own EventQueue in PlanningSceneMonitor

... to become independent of any capabilities that might block the global queue

* PlanningSceneMonitor: accept parent NodeHandle

* add MIGRATION note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.