Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing initial pose behavior when using the fake_controller_manager #1092

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@mlautman
Copy link
Member

commented Oct 16, 2018

This change handles a bug in the fake_controller_manager where the initial pose message was being missed some large percentage of the time.

The relevant code was initially added by Ioan and updated by @rhaschke in e1d91fe

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Oct 16, 2018

Could you please explain, how/why latching solves the problem?

@rhaschke rhaschke merged commit d1ba16d into ros-planning:kinetic-devel Oct 16, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

rhaschke added a commit to ubi-agni/moveit that referenced this pull request Oct 16, 2018

@davetcoleman davetcoleman deleted the PickNikRobotics:initial-pose branch Oct 17, 2018

@mlautman

This comment has been minimized.

Copy link
Member Author

commented Oct 18, 2018

According to the docs, latch "If true, the last message published on this topic will be saved and sent to new subscribers when they connect"
http://docs.ros.org/kinetic/api/roscpp/html/classros_1_1NodeHandle.html#a6b655c04f32c4c967d49799ff9312ac6

I believe the issue was that the robot_state_publisher was missing the initial joint state message

@rhaschke

This comment has been minimized.

Copy link
Collaborator

commented Oct 19, 2018

Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.