Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include chomp packages in a dependency chain starting from moveit metapkg #1127

Merged
merged 1 commit into from Oct 24, 2018

Conversation

Projects
None yet
2 participants
@130s
Copy link
Member

commented Oct 24, 2018

Description

Per my suggestion #1083 (comment) that is based on the discussion at ros-gbp/moveit-release#5 (comment), chomp packages will be included in the list of released packages.

For the chomp packages to be easily installed by just installing moveit (e.g. apt-get install ros-%DISTRO%-moveit), those packages need to be included in the dependency chain that's rooted from moveit. The change in this PR realizes that.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Decide if this should be cherry-picked to other current ROS branches -> Should be ported to melodic. Not for older than Kinetic. See ros-gbp/moveit-release#5 (comment)
  • Extended the tutorials / documentation, if necessary reference -> No need as this is not feature/enhancement change.
  • Include a screenshot if changing a GUI -> No GUI change.
  • Document API changes relevant to the user in the moveit/MIGRATION.md notes -> No API change. See more at #1083 (comment)
  • Created tests, which fail without this PR reference -> I can't think of anything to test for this particular change.

@130s 130s requested review from davetcoleman and rhaschke Oct 24, 2018

@davetcoleman davetcoleman referenced this pull request Oct 24, 2018

Closed

2018 Fall Release Kinetic and Melodic #1083

11 of 11 tasks complete

@130s 130s merged commit 95050e3 into ros-planning:kinetic-devel Oct 24, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@130s 130s deleted the 130s:release_chompif/k branch Oct 24, 2018

@130s

This comment has been minimized.

Copy link
Member Author

commented Oct 24, 2018

Cherry-picked to melodic-devel at 37def08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.