Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced deprecated cmake_modules with Eigen #1134

Merged

Conversation

Projects
None yet
2 participants
@rhaschke
Copy link
Collaborator

commented Oct 25, 2018

Kinetic release build fails missing cmake_modules. While we removed it from package.xml, it's still present in some CMakeLists. Running a pre-release test to verify.
In contrast to #976, I think the correct solution is to replace deprecated cmake_modules/FindEigen with find_package(eigen), which we actually already did. But some find_package(cmake_module) were left.

@rhaschke rhaschke changed the title replaced obsolete cmake_modules with Eigen replaced deprecated cmake_modules with Eigen Oct 25, 2018

@davetcoleman davetcoleman merged commit 79df7da into ros-planning:kinetic-devel Oct 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

rhaschke added a commit to ubi-agni/moveit that referenced this pull request Oct 26, 2018

rhaschke added a commit that referenced this pull request Oct 26, 2018

@rhaschke rhaschke deleted the ubi-agni:fix-kinetic-release branch Oct 27, 2018

ggupta9777 added a commit to ggupta9777/moveit that referenced this pull request Mar 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.