Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
MSA: cleanup includes to speedup compiling #1205
v4hn left a comment
Per se there's nothing wrong with these changes, although I wouldn't backport them to kinetic. (changing header includes is API changes)
Did you benchmark the compile times? I would be surprised if this makes a reasonable difference.
Not yet, because locally I'm using ccache. However, after merging, I'm curious to compare compile times on the ROS build farm, which doesn't use ccache. In the past, I have observed reductions in compile time, particularly when limiting template stuff (boost) to cpps.