Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code as of Lunar #1211

Merged

Conversation

Projects
None yet
3 participants
@davetcoleman
Copy link
Member

commented Nov 21, 2018

Addresses code comments:

#warning "This header is deprecated and will go away in ROS lunar."\
         "Please use moveit/move_group_interface/move_group_interface.h"\
         "and the class MoveGroupInterface instead of MoveGroup"

@davetcoleman davetcoleman requested a review from rhaschke Nov 21, 2018

rhaschke added some commits Nov 21, 2018

@rhaschke rhaschke merged commit ef301a7 into ros-planning:melodic-devel Nov 21, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@v4hn

This comment has been minimized.

Copy link
Member

commented Nov 26, 2018

post-merge insight:
we did not remove this in lunar because maintainers requested it stays in until melodic.
It is perfectly justified to remove it in melodic.

@davetcoleman

This comment has been minimized.

Copy link
Member Author

commented Nov 26, 2018

Great, that's exactly what i did!

@davetcoleman davetcoleman deleted the davetcoleman:melodic-remove-lunar branch Nov 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.