Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New command line utility tool to print planning scene info #1239

Merged
merged 1 commit into from Dec 19, 2018

Conversation

Projects
None yet
3 participants
@davetcoleman
Copy link
Member

davetcoleman commented Dec 3, 2018

There was already a moveit_print_planning_model_info utility so I copied that and adapted it as a debugging tool for the planning_scene attached objects

@davetcoleman

This comment has been minimized.

Copy link
Member Author

davetcoleman commented Dec 3, 2018

Added to tutorials: ros-planning/moveit_tutorials#263

@v4hn
Copy link
Member

v4hn left a comment

Looks good apart from a bit of nitpick.

@davetcoleman davetcoleman force-pushed the davetcoleman:melodic-print-planning-scene-info branch from 65077ac to 911fc92 Dec 10, 2018

@davetcoleman davetcoleman force-pushed the davetcoleman:melodic-print-planning-scene-info branch from 911fc92 to c71da36 Dec 18, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member Author

davetcoleman commented Dec 18, 2018

Fixed @v4hn's comments

@@ -1,5 +1,9 @@
<!-- -*- mode: XML -*- -->

This comment has been minimized.

@v4hn

v4hn Dec 19, 2018

Member

I'll merge this as is, but what is up with this header?
The standard header for xml is <?xml version="1.0"?>.
Does your IDE not recognize this one or did I miss a change in preferred format?

This comment has been minimized.

@davetcoleman

davetcoleman Dec 21, 2018

Author Member

I've used this for a long time and emacs does properly format the file when its included. Not sure where it came from though, but its in my templates

This comment has been minimized.

@rhaschke

rhaschke Dec 24, 2018

Contributor

That's just a header for emacs to "announce" the file mode for emacs. Not related to XML.

@v4hn

v4hn approved these changes Dec 19, 2018

@v4hn v4hn merged commit cfaf7eb into ros-planning:melodic-devel Dec 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Dec 19, 2018

Merged.

@davetcoleman I suppose there is no need to backport to kinetic, right?
This would change command line output, although not necessarily in a problematic way.

@davetcoleman davetcoleman deleted the davetcoleman:melodic-print-planning-scene-info branch Dec 21, 2018

davetcoleman added a commit to davetcoleman/moveit that referenced this pull request Dec 21, 2018

@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Dec 25, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member Author

davetcoleman commented Dec 31, 2018

I had bundled the fix in another PR already, but it looks like that won't get merged #1157

New PR: #1289

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.