Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup ControllerManagers #1352

Merged
merged 5 commits into from Feb 18, 2019

Conversation

Projects
None yet
2 participants
@rhaschke
Copy link
Collaborator

commented Feb 17, 2019

  • improve (mostly formatting) of comments
  • simplify parsing of controller_list, centrally checking for availability of required keys

rhaschke added some commits Feb 17, 2019

cleanup SimpleControllerManager
- use LOGNAME
- FollowJointTrajectoryControllerHandle
  - separate header and source
  - separate function errorCodeToMessage()

@rhaschke rhaschke force-pushed the ubi-agni:cleanup-execution branch from be93415 to 6f4a4aa Feb 18, 2019

@rhaschke rhaschke merged commit 749846f into ros-planning:melodic-devel Feb 18, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rhaschke rhaschke deleted the ubi-agni:cleanup-execution branch Feb 20, 2019

@130s

This comment has been minimized.

Copy link
Member

commented Feb 23, 2019

Just wondering who reviewed this merged PR.

@rhaschke

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 23, 2019

I accidentally merged several PRs, see #1356.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.