re-enable support for cmake 2.8.11 #391

Merged
merged 1 commit into from Dec 30, 2016

Conversation

Projects
None yet
3 participants
@v4hn
Member

v4hn commented Dec 29, 2016

842b590 introduced a minimum cmake of 2.8.12.
This was fully reasonable and worked at that time.
But the obsolete ubuntu saucy only provided 2.8.11 and it seems OSRF
now forces us to support this version more-or-less "for technical reasons".

This commit moves back to 2.8.11 and follows the advice of qt developers
to circumvent an old compile-flags problem with Qt5.

Notice that I did not have the chance to compile this on a saucy system!

re-enable support for cmake 2.8.11
842b590 introduced a minimum cmake of 2.8.12.
This was fully reasonable and worked at that time.
But the obsolete ubuntu saucy only provided 2.8.11 and it seems OSRF
now forces us to support this version more-or-less "for technical reasons".

This commit moves back to 2.8.11 and follows the advice of qt developers
to circumvent an old compile-flags problem with Qt5.
@v4hn

This comment has been minimized.

Show comment
Hide comment
@v4hn

v4hn Dec 29, 2016

Member

This is my take on #389 .

Member

v4hn commented Dec 29, 2016

This is my take on #389 .

@130s

This comment has been minimized.

Show comment
Hide comment
@130s

130s Dec 30, 2016

Member

Thanks, once I'm done making Saucy docker image osrf/docker_images#42 I'll test this on.

Member

130s commented Dec 30, 2016

Thanks, once I'm done making Saucy docker image osrf/docker_images#42 I'll test this on.

@130s

This comment has been minimized.

Show comment
Hide comment
@130s

130s Dec 30, 2016

Member

Ok, this builds successfully on Saucy docker. Merging. Thanks @v4hn!

FYI here's the command set on docker using the image osrf/docker_images#42. I'll try to automate Saucy job on moveit_ci soon.

$ docker run -t -i ros-indigo-saucy-core
# cd /tmp/
# mkdir -p cws_moveit/src
# cd cws_moveit/src
# git clone git@github.com:v4hn/moveit.git
# apt-get install ssh
# apt-get update
# git clone git@github.com:v4hn/moveit.git
# git clone https://github.com/ros-planning/moveit.git
# apt-get install python-catkin-tools
# cd src/moveit/
# git remote add v4hn https://github.com/v4hn/moveit.git
# git fetch v4hn
# git checkout -b test/391
# git rebase v4hn/pr-indigo-support-cmake-2.8.11
# cd ..
# rosdep install -r -y --from-paths src --ignore-src --as-root apt:false
# apt-get update
# apt-get install -y ros-indigo-dynamic-reconfigure
# catkin build moveit
:
Starting ==> moveit_setup_assistant                                                      
Finished <== moveit_ros_benchmarks_gui        [ 40.1 seconds ]                           
Finished <== moveit_setup_assistant           [ 1 minute and 11.0 seconds ]              
[build] Finished.                                                                        
[build] Runtime: 9 minutes and 37.9 seconds 
# lsb_release -a
No LSB modules are available.
root@69f9a99fef4f:/tmp/cws_moveit# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 13.10
Release:        13.10
Codename:       saucy
# cd moveit/
# git log
commit e7c0cd28a04f666f68619c56fa0538f6c7c54f18
Author: v4hn <me@v4hn.de>
Date:   Thu Dec 29 09:42:51 2016 +0100

    re-enable support for cmake 2.8.11
    
    842b590cbe3cafa1e9e6e00989235ef26a6fcf91 introduced a minimum cmake of 2.8.12.
    This was fully reasonable and worked at that time.
    But the obsolete ubuntu saucy only provided 2.8.11 and it seems OSRF
    now forces us to support this version more-or-less "for technical reasons".
    
    This commit moves back to 2.8.11 and follows the advice of qt developers
    to circumvent an old compile-flags problem with Qt5.

Some tips (disclaimer: I'm no docker expert):

  • git clone fails as this error and for some reason ssh can't be installed Use http instead of digging further.
  • rosdep fails at sudo apt-get. Use --as-root e.g.: rosdep install -r -y --from-paths src --ignore-src --as-root apt:false
Member

130s commented Dec 30, 2016

Ok, this builds successfully on Saucy docker. Merging. Thanks @v4hn!

FYI here's the command set on docker using the image osrf/docker_images#42. I'll try to automate Saucy job on moveit_ci soon.

$ docker run -t -i ros-indigo-saucy-core
# cd /tmp/
# mkdir -p cws_moveit/src
# cd cws_moveit/src
# git clone git@github.com:v4hn/moveit.git
# apt-get install ssh
# apt-get update
# git clone git@github.com:v4hn/moveit.git
# git clone https://github.com/ros-planning/moveit.git
# apt-get install python-catkin-tools
# cd src/moveit/
# git remote add v4hn https://github.com/v4hn/moveit.git
# git fetch v4hn
# git checkout -b test/391
# git rebase v4hn/pr-indigo-support-cmake-2.8.11
# cd ..
# rosdep install -r -y --from-paths src --ignore-src --as-root apt:false
# apt-get update
# apt-get install -y ros-indigo-dynamic-reconfigure
# catkin build moveit
:
Starting ==> moveit_setup_assistant                                                      
Finished <== moveit_ros_benchmarks_gui        [ 40.1 seconds ]                           
Finished <== moveit_setup_assistant           [ 1 minute and 11.0 seconds ]              
[build] Finished.                                                                        
[build] Runtime: 9 minutes and 37.9 seconds 
# lsb_release -a
No LSB modules are available.
root@69f9a99fef4f:/tmp/cws_moveit# lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 13.10
Release:        13.10
Codename:       saucy
# cd moveit/
# git log
commit e7c0cd28a04f666f68619c56fa0538f6c7c54f18
Author: v4hn <me@v4hn.de>
Date:   Thu Dec 29 09:42:51 2016 +0100

    re-enable support for cmake 2.8.11
    
    842b590cbe3cafa1e9e6e00989235ef26a6fcf91 introduced a minimum cmake of 2.8.12.
    This was fully reasonable and worked at that time.
    But the obsolete ubuntu saucy only provided 2.8.11 and it seems OSRF
    now forces us to support this version more-or-less "for technical reasons".
    
    This commit moves back to 2.8.11 and follows the advice of qt developers
    to circumvent an old compile-flags problem with Qt5.

Some tips (disclaimer: I'm no docker expert):

  • git clone fails as this error and for some reason ssh can't be installed Use http instead of digging further.
  • rosdep fails at sudo apt-get. Use --as-root e.g.: rosdep install -r -y --from-paths src --ignore-src --as-root apt:false

@130s 130s merged commit fe12e0c into ros-planning:indigo-devel Dec 30, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davetcoleman

This comment has been minimized.

Show comment
Hide comment
@davetcoleman

davetcoleman Dec 30, 2016

Member

Thanks @130s - if you move forward with a moveit_ci test I'd recommend building off of my pre-existing work for Wily. I finished creating the CI test, but various MoveIt tests were failing during actual pull requests that are Wily-specific problems, so it never got merged:
ros-planning/moveit_ci#20

You'll also need to create a Saucy docker image like this one: https://github.com/ros-planning/moveit/blob/kinetic-devel/.docker/ci-wily/Dockerfile

Member

davetcoleman commented Dec 30, 2016

Thanks @130s - if you move forward with a moveit_ci test I'd recommend building off of my pre-existing work for Wily. I finished creating the CI test, but various MoveIt tests were failing during actual pull requests that are Wily-specific problems, so it never got merged:
ros-planning/moveit_ci#20

You'll also need to create a Saucy docker image like this one: https://github.com/ros-planning/moveit/blob/kinetic-devel/.docker/ci-wily/Dockerfile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment