Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set planning frame correctly in evaluation of reachable and valid pos… #476

Merged
merged 1 commit into from Mar 26, 2017

Conversation

Projects
None yet
3 participants
@Jntzko
Copy link

commented Mar 24, 2017

The current behavior is that the evaluation sets the frame id of the goal_pose_ to the planning frame of the planning_scene_ when they are the same. This also applies for the pose.
This should be done when the frames are different.

Yannick Jonetzko
Set planning frame correctly in evaluation of reachable and valid pos…
…e filter

The current behavior is that the evaluation sets the frame id of the goal_pose_ to the planning frame of the
planning_scene_ when they are the same. This also applys for the pose.
This should be done when the frames are different.
@v4hn

v4hn approved these changes Mar 24, 2017

Copy link
Member

left a comment

This was a long-standing todo from our lab.

I have literally no idea why nobody noticed this before,
but then most people don't use the pick pipeline anyways...

@davetcoleman davetcoleman merged commit d3fcbb1 into ros-planning:indigo-devel Mar 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davetcoleman added a commit that referenced this pull request Mar 26, 2017

Set planning frame correctly in evaluation of reachable and valid pos…
…e filter (#476)

The current behavior is that the evaluation sets the frame id of the goal_pose_ to the planning frame of the
planning_scene_ when they are the same. This also applys for the pose.
This should be done when the frames are different.

davetcoleman added a commit that referenced this pull request Mar 26, 2017

Set planning frame correctly in evaluation of reachable and valid pos…
…e filter (#476)

The current behavior is that the evaluation sets the frame id of the goal_pose_ to the planning frame of the
planning_scene_ when they are the same. This also applys for the pose.
This should be done when the frames are different.
@davetcoleman

This comment has been minimized.

Copy link
Member

commented Mar 26, 2017

cherry-picked to J/K

@Jntzko Jntzko deleted the Jntzko:planningFrame branch Mar 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.