Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test if frame_dock_ exists in case of no window_context #525

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
2 participants
@Jntzko
Copy link

Jntzko commented Jun 13, 2017

This is a similar situation as in the pull request #523.

In the onInitialize function the frame_dock_ panel is only created if window_context exists.
Later on in the setName function the pointer is used without checking for existence.

@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Jun 16, 2017

@Jntzko format check failed. Could you clean this up please?

Yannick Jonetzko
Test if frame_dock_ exists in case of no window_context
In the onInitialize function the frame_dock_ panel is only created if window_context exists.
Later on in the setName function the pointer is used without checking for existence.

@Jntzko Jntzko force-pushed the Jntzko:fix-no-window_context branch from 382a42e to 7c6c078 Jun 19, 2017

@Jntzko

This comment has been minimized.

Copy link
Author

Jntzko commented Jun 19, 2017

Fixed it.

@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Jun 20, 2017

I just merged #523 and this is exactly the same context, just a different variable.
So I'll merge this one too.

@v4hn v4hn merged commit d9ed3f5 into ros-planning:indigo-devel Jun 20, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

v4hn added a commit that referenced this pull request Jun 20, 2017

Test if frame_dock_ exists in case of no window_context (#525)
In the onInitialize function the frame_dock_ panel is only created if window_context exists.
Later on in the setName function the pointer is used without checking for existence.

v4hn added a commit that referenced this pull request Jun 20, 2017

Test if frame_dock_ exists in case of no window_context (#525)
In the onInitialize function the frame_dock_ panel is only created if window_context exists.
Later on in the setName function the pointer is used without checking for existence.
@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Jun 20, 2017

picked to j/k

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.