Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use lookupParam() in kinematics plugins #714

Merged

Conversation

Projects
None yet
3 participants
@henningkayser
Copy link
Contributor

commented Dec 8, 2017

This PR replaces the param() calls inside moveit_kinematics plugins with the lookup function lookupParam() introduced here.

The lookup function looks for the parameters in the following locations:

  • ~/<group_name>/
  • ~/
  • robot_description_kinematics/<group_name>/
  • robot_description_kinematics/

Using this function allows setting the required parameters inside the kinematics.yaml either with or without the corresponding group name.

Since all of the plugins query some parameters under group_name in their private namespace, this location is added to lookupParam() with this commit.

@v4hn

@v4hn

v4hn approved these changes Dec 8, 2017

Copy link
Member

left a comment

I discussed these changes with @henhenhen before he filed the request.

I approve.

I believe we also want this back in indigo. It changes behavior, but it only looks at more locations for the parameters and will still work with the previous parameter locations.

@v4hn v4hn referenced this pull request Dec 10, 2017

Closed

New release 201711 #686

@130s 130s merged commit de87a6c into ros-planning:kinetic-devel Dec 18, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.