Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
MoveIt! tf2 migration #830
This is the migration from
This PR depends on the following upstream API changes for Melodic:
Things left TODO:
My solution was to just pass in a null
referenced this pull request
May 1, 2018
For now I think we'll need to go without the pull request builder, I have not had time to set this up yet.
Can you remove this from the first description if its ready?
You have an unfinished TODO in the first description:
These are ready?
I can rebase this down now, but I typically do this right before a merge, after the reviews are made and feedback is incorporated. Keeping them separate helps in viewing the history of the PR, but I admit 40 commits is an unwieldy number.
Yep. All of the code is ready. I'll update the checkbox accordingly.
rhaschke left a comment
Generally I approve these changes. @IanTheEngineer, thanks a lot for this great work! Some minor remarks inline.
@tfoote This PR uses the methods
I squashed most of the history of this PR, but it's still not quite ready for merging. I still have to
As it would require fully grokking how