Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSA: trim group + link names #921

Merged
merged 1 commit into from May 29, 2018

Conversation

Projects
None yet
2 participants
@rhaschke
Copy link
Collaborator

commented May 26, 2018

As pointed out in #919, leading and/or trailing white space in group names (but also link and joint names) cause issues. The underlying reason is that srdfdom actually trims those names during parsing. Hence, MSA should do the same. This PR fixes the most important occurences, but other names probably need trimming too...

@rhaschke rhaschke referenced this pull request May 26, 2018

Closed

Added check for whitespace in planning group name #919

1 of 5 tasks complete

@davetcoleman davetcoleman merged commit 5064494 into ros-planning:kinetic-devel May 29, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@davetcoleman

This comment has been minimized.

Copy link
Member

commented May 29, 2018

Thanks!

rhaschke added a commit to ubi-agni/moveit that referenced this pull request May 29, 2018

@rhaschke rhaschke deleted the ubi-agni:msa-trim-names branch May 29, 2018

dg-shadow added a commit to shadow-robot/moveit that referenced this pull request Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.