Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow optional namespace args #929

Merged
merged 2 commits into from Jun 3, 2018

Conversation

Projects
None yet
4 participants
@rhaschke
Copy link
Collaborator

rhaschke commented May 31, 2018

This fixes another regression introduced by #835: The newly introduced optional ns args are not declared as optional to python, thus resulting in errors like the following if omitted:

Traceback (most recent call last):
  File "/homes/rhaschke/src/ros/src/agni/agni-manipulation/agni_grasp_manager/scripts/grasp_manager.py", line 78, in __init__
    r = RobotInterface("robot_description")
Boost.Python.ArgumentError: Python argument types in
    RobotInterface.__init__(RobotInterface, str)
did not match C++ signature:
    __init__(_object*, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >)
@gavanderhoorn

This comment has been minimized.

Copy link
Member

gavanderhoorn commented May 31, 2018

I believe this was also reported by a user on ROS Answers: moveit_commander_cmdline.py Error.

@rhaschke

This comment has been minimized.

Copy link
Collaborator Author

rhaschke commented May 31, 2018

@willcbaker Please review as you originally requested #835.
There is also another open issue pending with this: #835 (review)

@rhaschke rhaschke force-pushed the ubi-agni:optional-ns-args branch from b0f8e7b to e316747 May 31, 2018

@rhaschke rhaschke force-pushed the ubi-agni:optional-ns-args branch from e316747 to 850ded6 May 31, 2018

@willcbaker

This comment has been minimized.

Copy link
Contributor

willcbaker commented May 31, 2018

@rhaschke looks good visually, still unable to test at this time

@v4hn v4hn merged commit 1543719 into ros-planning:kinetic-devel Jun 3, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

v4hn added a commit that referenced this pull request Jun 3, 2018

allow optional namespace args (#929)
allow optional namespace args

clang format of unrelated code in the same file
@v4hn

This comment has been minimized.

Copy link
Member

v4hn commented Jun 3, 2018

picked to melodic

dg-shadow added a commit to shadow-robot/moveit that referenced this pull request Jul 30, 2018

allow optional namespace args (ros-planning#929)
allow optional namespace args

clang format of unrelated code in the same file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.