Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed variable names in setup assistant widget to follow naming convention #995

Merged

Conversation

Projects
None yet
3 participants
@MohmadAyman
Copy link
Member

commented Jul 23, 2018

Description

Renamed widgets in setup assistant widget to follow naming convention

Checklist

  • Required: Code is auto formatted using clang-format
  • Extended the tutorials / documentation, if necessary reference
  • Include a screenshot if changing a GUI
  • Optional: Created tests, which fail without this PR reference
  • Optional: Decide if this should be cherry-picked to other current ROS branches (Indigo, Jade, Kinetic)

@MohmadAyman MohmadAyman force-pushed the MohmadAyman:follow_naming_convention branch from 7eb2da8 to 57a1fcb Jul 23, 2018

@MohmadAyman MohmadAyman force-pushed the MohmadAyman:follow_naming_convention branch from 57a1fcb to 4fb2c9e Jul 23, 2018

@MohmadAyman MohmadAyman changed the title Renamed widgets in setup assistant widget to follow naming convention Renamed variable names in setup assistant widget to follow naming convention Jul 25, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

i just resolved the merge conflict, hopefully this still passes travis

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 5, 2018

@mcevoyandy please review

@mcevoyandy
Copy link

left a comment

Looks good.

@davetcoleman davetcoleman merged commit 93cf277 into ros-planning:kinetic-devel Aug 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davetcoleman added a commit that referenced this pull request Aug 6, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Aug 6, 2018

cherry-picked to melodic

@MohmadAyman MohmadAyman referenced this pull request Aug 20, 2018

Closed

Setup Assistant 2 #894

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.