Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace C array with std::array in std::vector template argument #1612

Merged
merged 2 commits into from
Oct 17, 2022
Merged

Replace C array with std::array in std::vector template argument #1612

merged 2 commits into from
Oct 17, 2022

Conversation

light-tech
Copy link
Contributor

Description

When compiling on macOS, Apple clang (version 13.1.6) throws the same compilation error as the one reported moveit/moveit#3157 in MoveIt for ROS1 with the cause being invalid destructor call for C array type. So I made a simple change from C array to std::array to make the code more compatible with different C++ STL implementations.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 51.10% // Head: 51.07% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (8022d48) compared to base (cc63903).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1612      +/-   ##
==========================================
- Coverage   51.10%   51.07%   -0.02%     
==========================================
  Files         381      381              
  Lines       31738    31738              
==========================================
- Hits        16215    16206       -9     
- Misses      15523    15532       +9     
Impacted Files Coverage Δ
..._core/collision_detection/src/collision_common.cpp 50.00% <ø> (ø)
moveit_ros/moveit_servo/src/servo_calcs.cpp 66.45% <0.00%> (-1.49%) ⬇️
moveit_ros/moveit_servo/src/pose_tracking.cpp 76.78% <0.00%> (-0.47%) ⬇️
moveit_core/robot_state/src/robot_state.cpp 47.91% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vatanaksoytezer
Copy link
Contributor

@light-tech do you mind running pre commit as well? Otherwise looks good to me

@light-tech
Copy link
Contributor Author

@vatanaksoytezer Sure, I just did that.

@tylerjw
Copy link
Member

tylerjw commented Oct 17, 2022

I'm going to merge this next.

@tylerjw tylerjw added the backport-humble Mergify label that triggers a PR backport to Humble label Oct 17, 2022
@tylerjw tylerjw merged commit a8326ac into moveit:main Oct 17, 2022
mergify bot pushed a commit that referenced this pull request Oct 17, 2022
…mprove compatibility with clang compiler and libc++ (#1612)

Co-authored-by: Tyler Weaver <tyler@picknik.ai>
(cherry picked from commit a8326ac)
henningkayser pushed a commit that referenced this pull request Oct 28, 2022
…kport #1612) (#1621)

Co-authored-by: Tyler Weaver <tyler@picknik.ai>
(cherry picked from commit a8326ac)

Co-authored-by: light-tech <lightech@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble Mergify label that triggers a PR backport to Humble
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants