Use <> for non-local headers #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 50.97% // Head: 50.95% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
- Coverage 50.97% 50.95% -0.02%
==========================================
Files 378 378
Lines 31658 31658
==========================================
- Hits 16135 16128 -7
- Misses 15523 15530 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tylerjw
approved these changes
Nov 18, 2022
henningkayser
approved these changes
Nov 18, 2022
Unless a header lives in the same or a child directory of the file including it, it's recommended to use <> for the #include statement. For more information, see the C++ Core Guidelines item SF.12 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else
henningkayser
added
backport-galactic
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2022
Unless a header lives in the same or a child directory of the file including it, it's recommended to use <> for the #include statement. For more information, see the C++ Core Guidelines item SF.12 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else (cherry picked from commit 7a1f2a1) # Conflicts: # moveit_core/collision_detection_bullet/src/bullet_integration/bullet_cast_bvh_manager.cpp # moveit_core/collision_distance_field/include/moveit/collision_distance_field/collision_distance_field_types.h # moveit_core/collision_distance_field/include/moveit/collision_distance_field/collision_env_distance_field.h # moveit_core/constraint_samplers/include/moveit/constraint_samplers/default_constraint_samplers.h # moveit_core/kinematic_constraints/src/kinematic_constraint.cpp # moveit_core/kinematic_constraints/src/utils.cpp # moveit_core/planning_scene/include/moveit/planning_scene/planning_scene.h # moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h # moveit_core/trajectory_processing/include/moveit/trajectory_processing/iterative_spline_parameterization.h # moveit_core/trajectory_processing/include/moveit/trajectory_processing/iterative_time_parameterization.h # moveit_planners/pilz_industrial_motion_planner/include/joint_limits/joint_limits_rosparam.hpp # moveit_planners/pilz_industrial_motion_planner/include/pilz_industrial_motion_planner/limits_container.h # moveit_planners/pilz_industrial_motion_planner/src/command_list_manager.cpp # moveit_planners/pilz_industrial_motion_planner/src/joint_limits_container.cpp # moveit_planners/pilz_industrial_motion_planner/src/limits_container.cpp # moveit_planners/pilz_industrial_motion_planner/src/pilz_industrial_motion_planner.cpp # moveit_planners/pilz_industrial_motion_planner/src/trajectory_generator_ptp.cpp # moveit_ros/planning_interface/py_bindings_tools/src/roscpp_initializer.cpp # moveit_setup_assistant/moveit_setup_assistant/src/setup_assistant_widget.cpp # moveit_setup_assistant/moveit_setup_core_plugins/src/configuration_files_widget.cpp # moveit_setup_assistant/moveit_setup_core_plugins/src/start_screen_widget.cpp # moveit_setup_assistant/moveit_setup_framework/src/rviz_panel.cpp # moveit_setup_assistant/src/setup_assistant_main.cpp # moveit_setup_assistant/src/widgets/configuration_files_widget.h # moveit_setup_assistant/src/widgets/header_widget.cpp # moveit_setup_assistant/src/widgets/navigation_widget.cpp # moveit_setup_assistant/src/widgets/setup_assistant_widget.h # moveit_setup_assistant/src/widgets/start_screen_widget.h
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2022
Unless a header lives in the same or a child directory of the file including it, it's recommended to use <> for the #include statement. For more information, see the C++ Core Guidelines item SF.12 https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else (cherry picked from commit 7a1f2a1) # Conflicts: # moveit_core/robot_trajectory/include/moveit/robot_trajectory/robot_trajectory.h # moveit_planners/pilz_industrial_motion_planner/include/pilz_industrial_motion_planner/limits_container.h # moveit_planners/pilz_industrial_motion_planner/src/command_list_manager.cpp # moveit_planners/pilz_industrial_motion_planner/src/limits_container.cpp # moveit_planners/pilz_industrial_motion_planner/src/pilz_industrial_motion_planner.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1724.
Unless a header lives in the same or a child directory of the file including it, it's recommended to use <> for the #include statement.
For more information, see the C++ Core Guidelines item SF.12
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#sf12-prefer-the-quoted-form-of-include-for-files-relative-to-the-including-file-and-the-angle-bracket-form-everywhere-else
I tried to leave quotes around headers that exist in the same directory (or a child directory) of the file including them which his why not all headers are using
<>.