pre-release testing workflow for ros2 #118
Conversation
tylerjw
force-pushed
the
ros2-prerelease
branch
3 times, most recently
from
4f89c58
to
18eacae
Compare
|
There is not pre-release testing for galactic yet, but foxy and rolling seem to work. https://github.com/ros-planning/moveit_msgs/runs/2831886962?check_suite_focus=true |
tylerjw
force-pushed
the
ros2-prerelease
branch
2 times, most recently
from
0d385b3
to
ec4c608
Compare
Is there anything blocking that? I mean we can add this functionality to industrial_ci I think |
|
I reenabled the workflow dispatch test. Merge the other commit and then that feature will work and you can merge this one and use the pre-release test on either main or ros2 branches. |
.github/workflows/prerelease.yaml
Outdated
|
|
||
| on: | ||
| workflow_dispatch: | ||
| push: |
There was a problem hiding this comment.
Just for understanding... Couldn't we remove push here and get rid of the job guard?
There was a problem hiding this comment.
I think so. In a related note, is there any reason not wanting prerelease tests to run with every push or nightly?
There was a problem hiding this comment.
I think the reason is there is no concept of workflows that are allowed to fail with GitHub Actions. We will want to be able to merge changes between releases that will cause the pre-release test to fail.
There was a problem hiding this comment.
I pushed a change removing the push from this. I'm not sure what the original intent of having it here. I mostly copied this file from the moveit repo.
|
Now that there is a prerelease test in the default branch (master) I was able to manually trigger running the one in this branch: https://github.com/ros-planning/moveit_msgs/runs/2840796649?check_suite_focus=true |
I pushed this into the repo so we can run it on this branch to test if it works before merging.
It looks like industrial_ci supports pre-release testing for ros2: https://github.com/ros-industrial/industrial_ci/blob/master/industrial_ci/src/tests/ros_prerelease.sh#L25