Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding trigger call to animations if (batch_publishing_enabled_) #36

Merged

Conversation

Projects
None yet
2 participants
@mlautman
Copy link
Member

commented Sep 4, 2018

No description provided.

@mlautman mlautman requested a review from davetcoleman Sep 4, 2018

@@ -438,7 +438,8 @@ bool MoveItVisualTools::publishAnimatedGrasps(const std::vector<moveit_msgs::Gra
break;

publishAnimatedGrasp(possible_grasps[i], ee_jmg, animate_speed);

if (batch_publishing_enabled_)
trigger();
ros::Duration(0.1).sleep();

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Sep 6, 2018

Member

side note: this sleep should be customizable - e.g. pause_between_grasps

This comment has been minimized.

Copy link
@mlautman

mlautman Sep 13, 2018

Author Member

Can we reuse animate_sleep?

This comment has been minimized.

Copy link
@davetcoleman
@@ -438,7 +438,8 @@ bool MoveItVisualTools::publishAnimatedGrasps(const std::vector<moveit_msgs::Gra
break;

publishAnimatedGrasp(possible_grasps[i], ee_jmg, animate_speed);

if (batch_publishing_enabled_)
trigger();

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Sep 6, 2018

Member

interesting. it seems to me this trigger actually belongs inside publishAnimatedGrasp() because it has its own for-loop that publishes the motion of the end effector. thoughts?

This comment has been minimized.

Copy link
@mlautman

mlautman Sep 10, 2018

Author Member

Good point. Will change accordingly

This comment has been minimized.

Copy link
@mlautman

mlautman Sep 13, 2018

Author Member

done

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Sep 6, 2018

@mlautman Did you notice the " // Display Grasp Score" feature inside animate grasps?

@mlautman

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

@davetcoleman ready for merge?

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

i don't see any pushed updates to the code

@mlautman mlautman force-pushed the PickNikRobotics:trigger-animations branch from 43a4da0 to 12b6423 Sep 13, 2018

@mlautman

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2018

My bad. I hadn't pushed

@davetcoleman davetcoleman merged commit deecd1a into ros-planning:kinetic-devel Sep 14, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davetcoleman davetcoleman deleted the PickNikRobotics:trigger-animations branch Sep 14, 2018

davetcoleman added a commit that referenced this pull request Sep 14, 2018

@davetcoleman

This comment has been minimized.

Copy link
Member

commented Sep 14, 2018

cherry picked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.