Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gradient_path.cpp #576

Merged
merged 2 commits into from Nov 16, 2017

Conversation

Projects
None yet
3 participants
@ljy1992
Copy link

commented May 12, 2017

correct an obvious error at line 285

@DLu

This comment has been minimized.

Copy link
Contributor

commented May 30, 2017

Please update this to fix the equivalent line in navfn too

@DLu DLu added the planners label May 30, 2017

@ljy1992

This comment has been minimized.

Copy link
Author

commented Jun 5, 2017

I've changed the same place to the navfn code. I'm new to git, so is this the correct operation to add one more commits?

@mikeferguson

This comment has been minimized.

Copy link
Member

commented Jul 31, 2017

@DLu -- is your comment an approval of this fix? If so, I will merge and forward port to K+L

@DLu DLu merged commit 069152f into ros-planning:indigo-devel Nov 16, 2017

1 check passed

Ipr__navigation__ubuntu_trusty_amd64 Build finished.
Details

DLu added a commit to DLu/navigation that referenced this pull request Nov 16, 2017

Update gradient_path.cpp (ros-planning#576)
* Update gradient_path.cpp

* Update navfn.cpp

@DLu DLu referenced this pull request Nov 16, 2017

Merged

Rebase PRs from Indigo #636

DLu added a commit to DLu/navigation that referenced this pull request Nov 16, 2017

Update gradient_path.cpp (ros-planning#576)
* Update gradient_path.cpp

* Update navfn.cpp

@DLu DLu referenced this pull request Nov 16, 2017

Merged

Rebase PRs from Indigo/Kinetic #637

DLu added a commit that referenced this pull request Nov 30, 2017

Rebase PRs from Indigo (#636)
* Update gradient_path.cpp (#576)

* Update gradient_path.cpp

* Update navfn.cpp

* Only do a getRobotPose when no start pose is given (#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

DLu added a commit that referenced this pull request Nov 30, 2017

Rebase PRs from Indigo/Kinetic (#637)
* Respect planner_frequency intended behavior (#622)

* Only do a getRobotPose when no start pose is given (#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

* Update gradient_path.cpp (#576)

* Update gradient_path.cpp

* Update navfn.cpp

* update to use non deprecated pluginlib macro (#630)

* update to use non deprecated pluginlib macro

* multiline version as well

* Print SDL error on IMG_Load failure in server_map (#631)

gerkey added a commit to codebot/navigation that referenced this pull request Jan 19, 2018

Rebase PRs from Indigo (ros-planning#636)
* Update gradient_path.cpp (ros-planning#576)

* Update gradient_path.cpp

* Update navfn.cpp

* Only do a getRobotPose when no start pose is given (ros-planning#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

johaq added a commit to CentralLabFacilities/navigation that referenced this pull request Mar 30, 2018

Rebase PRs from Indigo (ros-planning#636)
* Update gradient_path.cpp (ros-planning#576)

* Update gradient_path.cpp

* Update navfn.cpp

* Only do a getRobotPose when no start pose is given (ros-planning#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

dantwinkler added a commit to 6RiverSystems/navigation that referenced this pull request Mar 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.