Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better fix for #523 respecting planner_frequency intended behavior #622

Merged
merged 1 commit into from Sep 12, 2017

Conversation

Projects
None yet
2 participants
@corot
Copy link
Contributor

commented Aug 31, 2017

Essentially I'm reverting 679ee2b but adding this line: https://github.com/ros-planning/navigation/compare/kinetic-devel...corot:better_fix_for_523?expand=1#diff-d6afbf7b921c7c246a6ee2454dc05be4R609

Now seems to work as expected: the new parameter max_retries does as expected, the planner stops while recovering and keeps replanning while moving if planner_frequency > 0

Not thoroughly tested, so please, give it a good try!

@DLu

This comment has been minimized.

Copy link
Contributor

commented Aug 31, 2017

LGTM, in my use case. Thanks for the quick fix.

@DLu DLu merged commit ac41d24 into ros-planning:kinetic-devel Sep 12, 2017

1 check passed

Kpr__navigation__ubuntu_xenial_amd64 Build finished.
Details

DLu added a commit to DLu/navigation that referenced this pull request Nov 16, 2017

@DLu DLu referenced this pull request Nov 16, 2017

Merged

Rebase PRs from Indigo/Kinetic #637

DLu added a commit that referenced this pull request Nov 30, 2017

Rebase PRs from Indigo/Kinetic (#637)
* Respect planner_frequency intended behavior (#622)

* Only do a getRobotPose when no start pose is given (#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

* Update gradient_path.cpp (#576)

* Update gradient_path.cpp

* Update navfn.cpp

* update to use non deprecated pluginlib macro (#630)

* update to use non deprecated pluginlib macro

* multiline version as well

* Print SDL error on IMG_Load failure in server_map (#631)

gerkey added a commit to codebot/navigation that referenced this pull request Jan 19, 2018

DLu added a commit to DLu/navigation that referenced this pull request Mar 20, 2018

johaq added a commit to CentralLabFacilities/navigation that referenced this pull request Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.