Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print SDL error on IMG_Load failure in server_map #631

Merged
merged 1 commit into from Nov 16, 2017

Conversation

Projects
None yet
2 participants
@Alabate
Copy link

commented Oct 27, 2017

When IMG_Load from SDL fail to load an image, the node stop without any message because a std::runtime_error is thrown without being catch.

This PR expose the SDL Error in the exception and then catch it properly, to print it as a ROS_ERROR.

For instance, if the image is too big, we get this log before the node stop:

[ INFO] [1509093324.779196221]: Loading map from image "map.png"
[ERROR] [1509093324.779879685]: failed to open image file "map.png": Out of memory

@DLu DLu merged commit 0b10dd7 into ros-planning:kinetic-devel Nov 16, 2017

1 check passed

Kpr__navigation__ubuntu_xenial_amd64 Build finished.
Details
@DLu

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

Thanks!

DLu added a commit to DLu/navigation that referenced this pull request Nov 16, 2017

@DLu DLu referenced this pull request Nov 16, 2017

Merged

Rebase PRs from Indigo/Kinetic #637

DLu added a commit that referenced this pull request Nov 30, 2017

Rebase PRs from Indigo/Kinetic (#637)
* Respect planner_frequency intended behavior (#622)

* Only do a getRobotPose when no start pose is given (#628)

Omit the unnecessary call to getRobotPose when the start pose was
already given, so that move_base can also generate a path in
situations where getRobotPose would fail.

This is actually to work around an issue of getRobotPose randomly
failing.

* Update gradient_path.cpp (#576)

* Update gradient_path.cpp

* Update navfn.cpp

* update to use non deprecated pluginlib macro (#630)

* update to use non deprecated pluginlib macro

* multiline version as well

* Print SDL error on IMG_Load failure in server_map (#631)

gerkey added a commit to codebot/navigation that referenced this pull request Jan 19, 2018

johaq added a commit to CentralLabFacilities/navigation that referenced this pull request Mar 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.