New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enable Message Filter in AMCL #171

Open
mhpanah opened this Issue Oct 15, 2018 · 7 comments

Comments

5 participants
@mhpanah
Collaborator

mhpanah commented Oct 15, 2018

currently geometry2 message_filter is not ported to ROS2. Once the message filter is ported to ROS2 we need to re-enable it in AMCL.

@gaoethan Would you be able to help us with this?

@mhpanah mhpanah added this to the October 2018 milestone Oct 15, 2018

@mhpanah mhpanah added this to To do in Navigation 2 Kanban via automation Oct 15, 2018

@gaoethan

This comment has been minimized.

gaoethan commented Oct 16, 2018

Yes. generally speaking, we can help on this. when do you plan to use it ?

@mkhansen-intel

This comment has been minimized.

Collaborator

mkhansen-intel commented Oct 16, 2018

@gaoethan - we're currently using a work-around in the code to make AMCL work without it, so we could use this change as soon as you can make it. How long would it take?

@mkhansen-intel mkhansen-intel added the task label Oct 17, 2018

@gaoethan

This comment has been minimized.

gaoethan commented Oct 18, 2018

Okay, I think that it's enough for me to port it for you in one week.

@mkhansen-intel

This comment has been minimized.

Collaborator

mkhansen-intel commented Oct 18, 2018

@gaoethan - 2 weeks is fine if you have other work that is higher priority

@yechun1

This comment has been minimized.

yechun1 commented Oct 18, 2018

Seems the message_filter interface of tf2_ros from geometry2 is not ported, let me have a try to port it.

@mkhansen-intel

This comment has been minimized.

Collaborator

mkhansen-intel commented Oct 23, 2018

Also linking to our issue on this #132

@mjeronimo mjeronimo modified the milestones: October 2018, November 2018 Nov 5, 2018

@gaoethan

This comment has been minimized.

gaoethan commented Nov 8, 2018

I've already worked out an available one, please have a try with the following code base:
https://github.com/gaoethan/message_filters.git with branch master
https://github.com/gaoethan/geometry2.git with branch tf2_ros_message_filters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment