Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[package.xml] Add active maintainers. Much wrong info. #12

Merged
merged 2 commits into from Aug 17, 2016

Conversation

@130s
Copy link
Member

130s commented Aug 15, 2016

No description provided.

package.xml Outdated
<author email="gwalck@techfak.uni-bielefeld.de">Guillaume Walck</author>
<maintainer email="isucan@willowgarage.com">Ioan Sucan</maintainer>
<maintainer email="isucan@gmail.com">Ioan Sucan</maintainer>

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Aug 16, 2016

Member

I just emailed @isucan to see if he wants to remain maintainer for packages like this, I'm fine either way

This comment has been minimized.

Copy link
@davetcoleman

davetcoleman Aug 16, 2016

Member

he suggested he be removed "from all instances" of package.xmls with him as a maintainer. I think we should also start a separate discussion on Discourse to find new active maintainers for all the packages - want to start that?

@davetcoleman

This comment has been minimized.

Copy link
Member

davetcoleman commented Aug 16, 2016

This is great, thanks!

[package.xml] Alphabetic order.
@130s 130s force-pushed the 130s:fix/manifest branch from bd81b97 to 5415450 Aug 16, 2016
@130s

This comment has been minimized.

Copy link
Member Author

130s commented Aug 16, 2016

Comment addressed.

package.xml Outdated
<build_depend>libconsole-bridge-dev</build_depend>
<build_depend>liburdfdom-headers-dev</build_depend>
<build_depend>rostest</build_depend>

This comment has been minimized.

Copy link
@v4hn

v4hn Aug 16, 2016

Member

shouldn't this be a test_depend instead?

This comment has been minimized.

Copy link
@davetcoleman

This comment has been minimized.

Copy link
@130s

130s Aug 16, 2016

Author Member

+1

@130s

This comment has been minimized.

Copy link
Member Author

130s commented Aug 16, 2016

Comment addressed again.
Also noticed that pkg-config is not needed (see the commit message for the rationale).

@davetcoleman davetcoleman merged commit c351dac into ros-planning:indigo-devel Aug 17, 2016
@130s 130s deleted the 130s:fix/manifest branch Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.