Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier joining of empty comments #9

Merged
merged 1 commit into from Oct 19, 2020
Merged

Prettier joining of empty comments #9

merged 1 commit into from Oct 19, 2020

Conversation

togaen
Copy link
Contributor

@togaen togaen commented Oct 19, 2020

Using logical operators on return status objects with empty comment strings previously would result in a comment string that looks like this:

obj1 && obj2 && obj3;
> "; AND ; AND ; AND "

These changes don't print conjunctions between empty strings:

obj1 && obj2 && obj3;
> ""

@togaen togaen requested a review from robbel October 19, 2020 16:25
@togaen togaen self-assigned this Oct 19, 2020
@robbel robbel merged commit ed7b93e into master Oct 19, 2020
@robbel robbel deleted the pretty-comment-join branch October 19, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants