Leave empty tf_prefix values unset #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this also fixes #333 (possibly a duplicate issue). |
jacobperron
reviewed
Aug 5, 2020
There was a problem hiding this comment.
Unfortunately, this kind of change risks breaking applications that rely on this functionality. It might be better to target noetic-devel to reduce disruption. For Melodic, we could add an option to opt-in to the new behavior. Though, I'm ambivalent considering use of tf_prefix has been deprecated for quite some time. Others should probably weigh-in.
scpeters
force-pushed
the
issue_554_melodic
branch
from
8a2792a
to
b8b8726
Compare
|
I just retargeted to noetic-devel |
jacobperron
approved these changes
Aug 11, 2020
As reported in ros-simulation#554, tf_prefix has been long deprecated, so if it is unset, leave it empty instead of giving a default value. Fixes ros-simulation#554. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
issue_554_melodic
branch
from
b8b8726
to
18c08cc
Compare
|
@osrf-jenkins run tests please |
|
looks like we missed one more instance of this in gazebo_ros_utils.cpp: |
scpeters
added a commit
to scpeters/gazebo_ros_pkgs
that referenced
this pull request
Sep 30, 2020
Similar changes were made in ros-simulation#1143 to address ros-simulation#554, but this class wasn't included. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
repeating this change for |
jacobperron
pushed a commit
that referenced
this pull request
Apr 2, 2021
cohen39
pushed a commit
to cohen39/gazebo_ros_pkgs
that referenced
this pull request
Nov 15, 2021
As reported in ros-simulation#554, tf_prefix has been long deprecated, so if it is unset, leave it empty instead of giving a default value. Fixes ros-simulation#554. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
cohen39
pushed a commit
to cohen39/gazebo_ros_pkgs
that referenced
this pull request
Nov 15, 2021
Similar changes were made in ros-simulation#1143 to address ros-simulation#554, but this class wasn't included. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #554, tf_prefix has been long deprecated, so if it is unset, leave it empty instead of giving a default value.
Fixes #554.