Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gazebo8 warnings part 1: replace Events::Disconnect* with pointer reset (lunar-devel) #626

merged 1 commit into from Nov 14, 2017


None yet
2 participants
Copy link

commented Nov 13, 2017

{ port of pull request #623 }
Alternative to #613 split into many parts.

sed -i \
  -e 's@[gazebo:]*event::Events::Disconnect[A-Za-z]*(\([^)]*\));@\1.reset();@' \
  $(grep -rlI Events::Disconnect .)

There were 983 warnings for #542; this should reduce that.

@j-rivero j-rivero merged commit 79840bc into lunar-devel Nov 14, 2017

2 of 4 checks passed

ros_gazebo8_pkgs-ci-pr_any_lunar-xenial-amd64 Build finished.
ros_gazebo_pkgs-ci-pr_regression_any_lunar-xenial-amd64 Build finished.
Lpr__gazebo_ros_pkgs__ubuntu_xenial_amd64 Build finished.
ros_gazebo_pkgs-ci-pr_any_lunar-xenial-amd64 Build finished.

@scpeters scpeters deleted the lunar-devel-transplant-623 branch Nov 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.