Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIFF DRIVE: wheel odometry twist is child frame #719

Merged

Conversation

Projects
None yet
2 participants
@kev-the-dev
Copy link
Collaborator

commented May 24, 2018

#717. In the diff drive plugin in with odometry source set to ENCODER, twist is published in global frame. This is against the convention specified in the Odometry message and inconsistent with there other mode (WORLD), where twist is published in the child frame.

@j-rivero

This comment has been minimized.

Copy link
Contributor

commented May 25, 2018

This is changing the behavior for users. Given the early moment of Melodic I'm going to accept it but for the other branches we would need a PR with legacy protection.

@j-rivero j-rivero merged commit 319b518 into ros-simulation:melodic-devel May 25, 2018

0 of 3 checks passed

Mpr__gazebo_ros_pkgs__ubuntu_bionic_amd64 Build finished.
Details
ros_gazebo_pkgs-ci-pr_any_melodic-bionic-amd64 Build finished.
Details
ros_gazebo_pkgs-ci-pr_regression_any_melodic-bionic-amd64 Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.