Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2: Port gazebo_dev to ament package #770

Merged
merged 3 commits into from Jul 17, 2018

Conversation

@kev-the-dev
Copy link
Collaborator

commented Jul 17, 2018

Convert gazebo_dev into an ament/colcon compatible package. This will allow for gazebo_ros and gazebo_plugins to depend on gazebo_dev to get headers/libraries from gazebo.

In package.xml, the dependency on gazebo is commented out with a TODO because colcon and ament fail to find gazebo on my system (though the cmake code works fine).

@@ -17,8 +18,15 @@

This comment has been minimized.

Copy link
@chapulina

chapulina Jul 17, 2018

Contributor

Sorry, I just realized the url lines have been removed for gazebo_msgs, mind bringing them back?

This comment has been minimized.

Copy link
@kev-the-dev

kev-the-dev Jul 17, 2018

Author Collaborator
kev-the-dev added 2 commits Jul 17, 2018
* currently dependency on gazebo is commented out as it cannot find it

<!-- Currently causes colcon/ament to fail even when they are installed
TODO: fix and uncomment
<build_export_depend>libgazebo9-dev</build_export_depend>
<exec_depend>gazebo9</exec_depend>

This comment has been minimized.

Copy link
@chapulina

chapulina Jul 17, 2018

Contributor

@mikaelarguedas just helped me debug this a bit and for me, upgrading the cmake minimum version to 3.5 solves the issue. Could you give that a try?

cmake_minimum_required(VERSION 3.5)

This comment has been minimized.

Copy link
@kev-the-dev

kev-the-dev Jul 17, 2018

Author Collaborator

Worked!

@kev-the-dev kev-the-dev force-pushed the kev-the-dev:ros2-gazebo-dev branch from 94aba73 to 6e4e61b Jul 17, 2018
@kev-the-dev kev-the-dev merged commit e52289c into ros-simulation:ros2 Jul 17, 2018
@dhood dhood added the ros2 label Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.