Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
gazebo_plugins: Port the gazebo_ros_p3d plugin #845
This is a port of the gazebo_ros_p3d plugin to ROS2. Tested with gazebo 9.0.0.
Example plugin XML:
chapulina left a comment •
Thank you again for the PR, @mjeronimo ! I know I left a lot of comments, but that's mainly our fault, not yours. A lot has changed from ROS 1 to ROS 2, and although we've been writing migration guides for downstream developers, we're lacking a guide specific for contributors like you. I'm going to work on this soon.
Meanwhile, besides the comments I left:
I realize this seems like a lot, but hopefully the existing plugins will take you a long way. Don't hesitate to ask questions.
@mjeronimo , I went ahead and tackled the remaining items in the list:
Let me know if you have any concerns, I'm ready to merge once you approve the latest changes.
By the way, I also added a contribution guide here.